Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running tests from PR diff deletes it #169855

Closed
jrieken opened this issue Dec 22, 2022 · 2 comments
Closed

Running tests from PR diff deletes it #169855

jrieken opened this issue Dec 22, 2022 · 2 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s) important Issue identified as high-priority

Comments

@jrieken
Copy link
Member

jrieken commented Dec 22, 2022

  • open Configuration perf tweaks #169828 in PR extension
  • open src/vs/platform/configuration/test/common/configurationModels.test.ts in diff editor
  • run the newly added test
  • 🐛 it gets removed, file is now dirty...
Screen.Recording.2022-12-22.at.16.56.47.mov
@jrieken jrieken added the important Issue identified as high-priority label Dec 22, 2022
@connor4312
Copy link
Member

This is because the "revert change" arrow underlaps the testing gutter icon, but the event is still handled; this happens if the test range also starts on the first line of a diff segment. Merging this into #114776

@connor4312 connor4312 added the *duplicate Issue identified as a duplicate of another issue(s) label Dec 26, 2022
@vscodenpa
Copy link

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for similar existing issues. See also our issue reporting guidelines.

Happy Coding!

@vscodenpa vscodenpa closed this as not planned Won't fix, can't repro, duplicate, stale Dec 26, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Feb 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s) important Issue identified as high-priority
Projects
None yet
Development

No branches or pull requests

4 participants