Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows: allow more styles in the menu bar and hide the title bar #17009

Closed
Tekbr opened this issue Dec 10, 2016 · 6 comments
Closed

Windows: allow more styles in the menu bar and hide the title bar #17009

Tekbr opened this issue Dec 10, 2016 · 6 comments
Assignees
Labels
feature-request Request for new features or functionality ux User experience issues

Comments

@Tekbr
Copy link

Tekbr commented Dec 10, 2016

  • VSCode Version: 1.7.2
  • OS Version: Windows 10

-- Sorry for the English, I used Google Translator --

Allowing show / hide equal title bar happens with Firefox.

gif2

Allow the menu bar to receive the color of the VSCode theme, just like in Firefox, rather than gray.

gif1

gif3

Follow a print (very ugly) to get an idea of how it could stay.

When we leave the Menu bar active.

img2

When we hide the menu bar..

img3

When we have a group of tabs with the Menu bar hidden.

img4

The background color of the mininize, restore / maximize, and close buttons should change color along with the theme, but when hovering over it it should change color to gray when mininize and restore / maximize and red when closed, as it currently is .

@bpasero bpasero added feature-request Request for new features or functionality ux User experience issues workbench labels Dec 12, 2016
@bpasero bpasero assigned stevencl and unassigned bpasero Dec 12, 2016
@stevencl
Copy link
Member

Thanks for the feedback.

We have the ability to toggle the menu bar on and off at the moment (from the View menu).

@bgashler1 has been working on theming, with one of the ideas being to allow the title bar to take on the VS Code theme colours (see the full issue here: #3112 - Brad's comments and proposal are further on in the thread).

Let me know if this covers what you are proposing here.

@Tekbr
Copy link
Author

Tekbr commented Dec 12, 2016

@stevencl Yes, I know we can hide the menu bar.
But what I'm talking about as a suggestion is to hide the title bar, so note that the options to minimize restore / maximize and close are in the same position as the menu bar items.

If I also resolve to hide the menu bar the options to minimize restore / maximize and close remain in the same position as the tabs.

Sorry for the English and the placed images.

See if the explanation is better now.

@stevencl
Copy link
Member

Thanks!

We've investigated hiding the title bar too but the challenge we have not yet been able to fully solve is how to support dragging individual tabs and the full window when there is no title bar, if the tabs remain full height. Our only solution has been to add space above the tabs which the user can drag to move the whole window. This is effectively a title bar, albeit potentially a smaller one to the one we have today.

@Tekbr
Copy link
Author

Tekbr commented Dec 12, 2016

@stevencl I think the biggest problem will be when you have a group of guides and not when you have a single group (since this situation looks like how browsers work Edge, Firefox, Chrome.)

I do not know if it's possible:

Note that when we have many tabs open in browsers, they also leave a space between the minimize button and the button for a new tab. Could this space be placed and be used to drag the window?

See that when we lower the Firefox and Chrome window it adds a space so that the entire window can be dragged. Could this space be added to when you have a group of tabs and when the window is dimmed?

@be5invis
Copy link
Contributor

Maybe useful (based on @flagello’s Essence):


@stevencl
Copy link
Member

Thanks for all the suggestions. I'm trying to keep track of the requirements and suggestions in this issue: #17060

Would love to hear your thoughts there.

I'll close this issue just now so that we can keep all the discussion and suggestions in one place.

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality ux User experience issues
Projects
None yet
Development

No branches or pull requests

5 participants