Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should vscode.workspace.fs.stat API return all content providered by User-defined FileSystem provider #170539

Closed
yiliang114 opened this issue Jan 4, 2023 · 1 comment
Assignees
Labels
*as-designed Described behavior is as designed

Comments

@yiliang114
Copy link
Contributor

I use vscode.FileSystemProvider interface when I develop a VS Code Extension. I have implemented the stat function, which inherits vscode.FileStat and contains some additional attributes. But when I used vscode.workspace.fs.stat to try to get the extra properties I injected, I found that I didn't get them.

Should vscode.workspace.fs.stat API return all content providered by User-defined FileSystem provider Instead of returning only the following attributes?

image

extHostFileSystemConsumer Stat

@jrieken
Copy link
Member

jrieken commented Jan 4, 2023

Should vscode.workspace.fs.stat API return all content providered by User-defined FileSystem provider Instead of returning only the following attributes?

We don't do that because we want the API to work as advertised - meaning neither more nor less than spec'd. Otherwise (other) extensions would become dependent on a specific implement extension of another extensions and that would defeat the purpose of the API in the first place

@jrieken jrieken closed this as completed Jan 4, 2023
@jrieken jrieken added the *as-designed Described behavior is as designed label Jan 4, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Feb 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*as-designed Described behavior is as designed
Projects
None yet
Development

No branches or pull requests

2 participants