Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto publishing: Create New Codespace fails #172148

Closed
chrmarti opened this issue Jan 24, 2023 · 5 comments · Fixed by #172324
Closed

Auto publishing: Create New Codespace fails #172148

chrmarti opened this issue Jan 24, 2023 · 5 comments · Fixed by #172324
Assignees
@joyceerhl
Labels
bug Issue identified by VS Code Team member as probable bug continue-working-on git GIT issues verified Verification succeeded
Milestone
January 2023

Comments

@chrmarti
Copy link
Collaborator

Testing #172030

Choosing Never failed:
image
@chrmarti chrmarti changed the title Auto publishing: Not to publish fails Auto publishing: Codespaces fails Jan 24, 2023
@chrmarti chrmarti changed the title Auto publishing: Codespaces fails Auto publishing: Create New Codespace fails Jan 24, 2023
@chrmarti
Copy link
Collaborator Author

Choosing Always also failed:
image

@chrmarti
Copy link
Collaborator Author

I was using a public repo: https://github.com/chrmarti/smktst

@bamurtaugh
Copy link
Member

I experience the same on Windows 11 with the repo: https://github.com/bamurtaugh/theCatSaidNo.

@joyceerhl joyceerhl added bug Issue identified by VS Code Team member as probable bug git GIT issues continue-working-on labels Jan 24, 2023
@joyceerhl joyceerhl added this to the January 2023 milestone Jan 24, 2023
@joyceerhl joyceerhl mentioned this issue Jan 25, 2023
Merged
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jan 25, 2023
@bhavyaus
Copy link
Collaborator

Create New Codespace still fails with ContinueOn

@bhavyaus bhavyaus reopened this Jan 27, 2023
@bhavyaus bhavyaus added the verification-found Issue verification failed label Jan 27, 2023
@vscodenpa vscodenpa removed the insiders-released Patch has been released in VS Code Insiders label Jan 27, 2023
@joyceerhl
Copy link
Collaborator

joyceerhl commented Jan 27, 2023 •
edited
Loading

The original issue reported here was due to the fact that we weren't properly awaiting the branch publish before invoking the codespace creation. @bhavyaus based on our offline discussion I think you're encountering a different issue because the publish completes but the codespace creation doesn't start, and only if you aren't signed into the GitHub Codespaces extension, so I'm going to close this issue and we can file a new one to investigate the scenario you've uncovered since I can't reproduce it at the moment: #172654.

@roblourens roblourens removed the verification-found Issue verification failed label Jan 27, 2023
@rzhao271 rzhao271 added the verified Verification succeeded label Jan 27, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Mar 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joyceerhl joyceerhl

Labels
bug Issue identified by VS Code Team member as probable bug continue-working-on git GIT issues verified Verification succeeded
Projects
None yet
Milestone
January 2023
Development

Successfully merging a pull request may close this issue.

Fix auto publish before Continue On microsoft/vscode
7 participants
@roblourens @rzhao271 @chrmarti @bhavyaus @bamurtaugh @joyceerhl @vscodenpa