Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trust UI should better differentiate selected and tabbed #172299

Open
karthiknadig opened this issue Jan 24, 2023 · 3 comments
Open

Trust UI should better differentiate selected and tabbed #172299

karthiknadig opened this issue Jan 24, 2023 · 3 comments
Assignees
Labels
themes Color theme issues

Comments

@karthiknadig
Copy link
Member

Testing #172101

Here, workspace is trusted (so the trusted block is "selected"), I tabbed to the block to untrust it. They look the same. My screen size is small, the button was cut-off it was confusing for a bit. The "selected" block probably should have some different visual indication.
image

Here is the reverse scenario, the workspace is untrusted and I tabbed on the block to trust it:
image

@sbatten
Copy link
Member

sbatten commented Jan 25, 2023

I believe this is a theme issue with the new Dark+ V2

@sbatten sbatten assigned daviddossett and unassigned sbatten Jan 25, 2023
@daviddossett
Copy link
Contributor

@sbatten I'm seeing this with any theme:

CleanShot.2023-01-31.at.11.28.53.mp4

@sbatten
Copy link
Member

sbatten commented Jan 31, 2023

@daviddossett GitHub Light Theme
image

@daviddossett daviddossett assigned hbons and unassigned daviddossett Mar 21, 2023
@daviddossett daviddossett added the themes Color theme issues label Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
themes Color theme issues
Projects
None yet
Development

No branches or pull requests

4 participants