Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terminal accessibility - accessibility model rendering issue #172513

Closed
lszomoru opened this issue Jan 26, 2023 · 5 comments
Closed

Terminal accessibility - accessibility model rendering issue #172513

lszomoru opened this issue Jan 26, 2023 · 5 comments
Assignees
@Tyriar @meganrogge
Labels
bug Issue identified by VS Code Team member as probable bug confirmed Issue has been confirmed by VS Code Team member regression Something that used to work is now broken terminal-accessibility Issues related to the terminal help widget, accessibility buffer, or navigation mode verified Verification succeeded
Milestone
February 2023

Comments

@lszomoru
Copy link
Member

lszomoru commented Jan 26, 2023 •
edited
Loading

Testing #171862

Terminal
image

Terminal (accessibility mode)

  • Scrollbar location seems off
  • There is old content on the right side of the scrollbar

image
@meganrogge meganrogge added confirmed Issue has been confirmed by VS Code Team member regression Something that used to work is now broken terminal-accessibility Issues related to the terminal help widget, accessibility buffer, or navigation mode bug Issue identified by VS Code Team member as probable bug labels Jan 26, 2023
@meganrogge meganrogge added this to the February 2023 milestone Jan 26, 2023
@Tyriar
Copy link
Member

Tyriar commented Jan 26, 2023

@meganrogge we might also want to keep the empty new lines?

@meganrogge
Copy link
Contributor

don't set the width

@Tyriar Tyriar mentioned this issue Feb 2, 2023
Merged
@meganrogge
Copy link
Contributor

We already don't set the width 🤔

@Tyriar
Copy link
Member

Tyriar commented Feb 2, 2023

@meganrogge i removed the width in the linked xterm.js change

@meganrogge
Copy link
Contributor

this is fixed with that change

@rzhao271 rzhao271 added the verified Verification succeeded label Feb 23, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Mar 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

@meganrogge meganrogge

Labels
bug Issue identified by VS Code Team member as probable bug confirmed Issue has been confirmed by VS Code Team member regression Something that used to work is now broken terminal-accessibility Issues related to the terminal help widget, accessibility buffer, or navigation mode verified Verification succeeded
Projects
None yet
Milestone
February 2023
Development

No branches or pull requests
4 participants
@Tyriar @lszomoru @rzhao271 @meganrogge