Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Partial acceptance doesn't work for multi-line completions #172541

Closed
bmuskalla opened this issue Jan 26, 2023 · 1 comment
Closed

Partial acceptance doesn't work for multi-line completions #172541

bmuskalla opened this issue Jan 26, 2023 · 1 comment
Assignees
@jrieken

Comments

@bmuskalla
Copy link

Does this issue occur when all extensions are disabled?: Yes/No

  • VS Code Version: Version: 1.75.0-insider (Universal)
    Commit: 270c3b1

Steps to Reproduce:

  1. Proposal provider with a multi-line completion
  2. Partial acceptance only works on the first line

Recording 2023-01-26 at 16 45 03

/cc @isidorn
@isidorn
Copy link
Contributor

isidorn commented Jan 26, 2023

Good catch, but duplicate of #172162
I think we should look into fixing it in the next couple of milestones.
fyi @hediet

@isidorn isidorn closed this as completed Jan 26, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Mar 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrieken jrieken

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bmuskalla @jrieken @isidorn