Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asynchronous error handling in quick pick #174476

Closed
TylerLeonhardt opened this issue Feb 15, 2023 · 2 comments
Closed

Asynchronous error handling in quick pick #174476

TylerLeonhardt opened this issue Feb 15, 2023 · 2 comments
Assignees
Labels
quick-pick Quick-pick widget issues under-discussion Issue is under discussion for relevance, priority, approach

Comments

@TylerLeonhardt
Copy link
Member

TylerLeonhardt commented Feb 15, 2023

Follow up from #173716

Here are three common scenarios in notebooks where we want to present warning/error messages to users and improve the UX
...

  • Empty results from a quick pick item entry. This usually happens when users pick a quick pick item, which goes to the next quick pick step, but at the end there is no result in that step. We currently show a placeholder quick pick item there but

    • It might be too late to show this option
    • The quick pick item is not actionable and also doesn't look like a warning/error message, compared to the validation message we usually show in quick picks.

Two options (both of which assume that you don't go to a new empty quick pick):

  • In quickpick, we have a core feature called validationMessage which shows a barebones message underneath the input. It is not like the input message validation which looks like it is attached to the input, it's just a piece of text right under the input. We could use this to display an error to the user that "something went wrong with that choice"
  • just show an error notification
@TylerLeonhardt TylerLeonhardt added quick-pick Quick-pick widget issues under-discussion Issue is under discussion for relevance, priority, approach labels Feb 15, 2023
@TylerLeonhardt TylerLeonhardt self-assigned this Feb 15, 2023
@TylerLeonhardt
Copy link
Member Author

@rebornix @DonJayamanne can you attach a screenshot of the current experience?

cc @daviddossett for thoughts

@TylerLeonhardt
Copy link
Member Author

Closing this since it's not talked about anymore

@TylerLeonhardt TylerLeonhardt closed this as not planned Won't fix, can't repro, duplicate, stale Dec 15, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jan 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
quick-pick Quick-pick widget issues under-discussion Issue is under discussion for relevance, priority, approach
Projects
None yet
Development

No branches or pull requests

2 participants