Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quick Pick: Images in the tooltip confuse the layout #174900

Open
hediet opened this issue Feb 21, 2023 · 3 comments
Open

Quick Pick: Images in the tooltip confuse the layout #174900

hediet opened this issue Feb 21, 2023 · 3 comments
Assignees
@Tyriar @TylerLeonhardt @sbatten
Labels
bug Issue identified by VS Code Team member as probable bug workbench-hover Hover issues in the workbench
Milestone
Backlog

Comments

@hediet
Copy link
Member

hediet commented Feb 21, 2023

Testing #174699

image

await this._quickInputService.pick([{ label: 'foobar', tooltip: new MarkdownString('[ggle](https://google.com) ![](https://user-images.githubusercontent.com/2931520/220311698-bf404e7f-3b25-4008-a436-324663fbe23b.gif)') }])
@TylerLeonhardt
Copy link
Member

@Tyriar @sbatten do you think this happened due to the Hover and ContextView trying to correct the location because the image goes off screen? Any thoughts on this?

@TylerLeonhardt TylerLeonhardt added the bug Issue identified by VS Code Team member as probable bug label Feb 27, 2023
@Tyriar
Copy link
Member

Tyriar commented Feb 27, 2023

I'm not sure the offscreen re-positioning has been tested with the tooltip with the arrow

@Tyriar Tyriar added this to the Backlog milestone Feb 27, 2023
@Tyriar Tyriar added the workbench-hover Hover issues in the workbench label Feb 27, 2023
@TylerLeonhardt
Copy link
Member

TylerLeonhardt commented Feb 27, 2023 •
edited
Loading

@Tyriar unsurprisingly I saw that with text tooltips as well. It didn't take much to cause the hover to reposition given that we only specify the hover to the right of the quick pick item (left would have the same problem, bottom/top wouldn't be great because it would cover up list items)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tyriar Tyriar

@TylerLeonhardt TylerLeonhardt

@sbatten sbatten

Labels
bug Issue identified by VS Code Team member as probable bug workbench-hover Hover issues in the workbench
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
4 participants
@Tyriar @TylerLeonhardt @hediet @sbatten