Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't install version 1.5.1 of Better Shell Syntax #177199

Closed
alexr00 opened this issue Mar 15, 2023 · 3 comments
Closed

Can't install version 1.5.1 of Better Shell Syntax #177199

alexr00 opened this issue Mar 15, 2023 · 3 comments
Assignees

Comments

@alexr00
Copy link
Member

alexr00 commented Mar 15, 2023

  1. Install jeff-hykin.better-shellscript-syntax. This will install 1.5.2.
  2. Now try to install a specific version and choose 1.5.1.
  3. See this error:
    image

Log:

2023-03-15 11:20:29.773 [error] Signature: PackageIntegrityCheckFailed
    at yt.download (c:\Users\alros\AppData\Local\Programs\Microsoft VS Code Insiders\resources\app\out\vs\code\node\sharedProcess\sharedProcessMain.js:93:468)
    at async X.x (c:\Users\alros\AppData\Local\Programs\Microsoft VS Code Insiders\resources\app\out\vs\code\node\sharedProcess\sharedProcessMain.js:93:20734)
    at async X.h (c:\Users\alros\AppData\Local\Programs\Microsoft VS Code Insiders\resources\app\out\vs\code\node\sharedProcess\sharedProcessMain.js:93:18874)
2023-03-15 11:20:29.792 [error] PackageIntegrityCheckFailed: Signature: PackageIntegrityCheckFailed
    at yt.download (c:\Users\alros\AppData\Local\Programs\Microsoft VS Code Insiders\resources\app\out\vs\code\node\sharedProcess\sharedProcessMain.js:93:468)
    at async X.x (c:\Users\alros\AppData\Local\Programs\Microsoft VS Code Insiders\resources\app\out\vs\code\node\sharedProcess\sharedProcessMain.js:93:20734)
    at async X.h (c:\Users\alros\AppData\Local\Programs\Microsoft VS Code Insiders\resources\app\out\vs\code\node\sharedProcess\sharedProcessMain.js:93:18874)

From @jeff-hykin in jeff-hykin/better-shell-syntax#54 (comment):

Nothing has changed on my end, same publish command / token. The CLI command does take significantly longer than usual the last two times, but I get the same output as usual:

image

Was there a recent change in VS Code signature validation? Like a format deprecation/drop

@alexr00
Copy link
Member Author

alexr00 commented Mar 15, 2023

@isidorn since you have been involved in extension signing.

@isidorn
Copy link
Contributor

isidorn commented Mar 15, 2023

We have not changed the VS Code signature validation. This looks like a bug.
Similar to #175733

fyi @dtivel

@isidorn
Copy link
Contributor

isidorn commented Mar 15, 2023

@dtivel confirmed that this is indeed duplicate of #175733 which is upstream of microsoft/vsmarketplace#619

@isidorn isidorn closed this as completed Mar 15, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Apr 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants