Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vscode.dev get crashed while saving a untitled editor #177638

Closed
harbin1053020115 opened this issue Mar 20, 2023 · 5 comments
Closed

vscode.dev get crashed while saving a untitled editor #177638

harbin1053020115 opened this issue Mar 20, 2023 · 5 comments
Assignees
Labels
freeze-slow-crash-leak VS Code crashing, performance, freeze and memory leak issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-linked This is an upstream issue that has been reported upstream vscode.dev Issues related to vscode.dev

Comments

@harbin1053020115
Copy link
Contributor

Does this issue occur when all extensions are disabled?: Yes/No

  • VS Code Version: 1.76.2
  • OS Version: macOS Monterey 12.6

Steps to Reproduce:

  1. New File:
    image
  2. Enter some code and enter Command + s
    image
  3. Chrome get crashed
@harbin1053020115
Copy link
Contributor Author

harbin1053020115 commented Mar 20, 2023

I have debug vscode source code and get this error(Source code at: https://github.com/microsoft/vscode/blob/main/src/vs/workbench/services/dialogs/browser/fileDialogService.ts#L127).
I have console.error(error) in catch(error) and get this:
Unhandled Rejection (SecurityError): Failed to execute 'showSaveFilePicker' on 'Window': Must be handling a user gesture to show a file picker.

@harbin1053020115
Copy link
Contributor Author

I have found the key code which cause the Chrome's crashing:

var types = [
  	{
        "description": "JSON",
        "accept": {
            "text/plain": [
                ".json",
                ".bowerrc",
                ".jscsrc",
                ".webmanifest",
                ".js.map",
                ".css.map",
                ".ts.map",
                ".har",
                ".jslintrc",
                ".jsonld"
            ]
        }
    }
];
window.showOpenFilePicker({ suggestedName: 'Untitled_1', startIn: undefined, types });

@harbin1053020115
Copy link
Contributor Author

This is a Chrome's issue, I have report issue for Chrome

@bpasero
Copy link
Member

bpasero commented Mar 20, 2023

Thanks for reporting to Chrome, can you put the link here for future reference?

@bpasero bpasero added upstream Issue identified as 'upstream' component related (exists outside of VS Code) freeze-slow-crash-leak VS Code crashing, performance, freeze and memory leak issues upstream-issue-linked This is an upstream issue that has been reported upstream vscode.dev Issues related to vscode.dev labels Mar 20, 2023
@bpasero bpasero closed this as not planned Won't fix, can't repro, duplicate, stale Mar 20, 2023
@harbin1053020115
Copy link
Contributor Author

Thanks for reporting to Chrome, can you put the link here for future reference?

https://bugs.chromium.org/p/chromium/issues/detail?id=1426323

@github-actions github-actions bot locked and limited conversation to collaborators May 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
freeze-slow-crash-leak VS Code crashing, performance, freeze and memory leak issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-linked This is an upstream issue that has been reported upstream vscode.dev Issues related to vscode.dev
Projects
None yet
Development

No branches or pull requests

4 participants