Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wrong cursor type when hovering a scrollbar in the scrollable notebook output #177724

Closed
amunger opened this issue Mar 20, 2023 · 1 comment · Fixed by #177744
Closed

wrong cursor type when hovering a scrollbar in the scrollable notebook output #177724

amunger opened this issue Mar 20, 2023 · 1 comment · Fixed by #177744
Assignees
@rebornix @amunger
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders notebook-output verified Verification succeeded
Milestone
March 2023

Comments

@amunger
Copy link
Contributor

amunger commented Mar 20, 2023

create a notebook with a cell that produces long output:

for i in range(1000):
    print(i)

hover over the scrollbar within the output, it should be the pointer, but it is text
@amunger amunger added bug Issue identified by VS Code Team member as probable bug notebook-output labels Mar 20, 2023
@amunger amunger self-assigned this Mar 20, 2023
@amunger amunger mentioned this issue Mar 20, 2023
Closed
3 tasks
@rebornix
Copy link
Member

vscode/extensions/notebook-renderers/src/index.ts

Lines 339 to 340 in a11d69c

cursor: text;
}

The scrollbar inherits the cursor style from this container and a important override in ::-webkit-scrollbar doesn't seem to work.

@amunger amunger mentioned this issue Mar 20, 2023
Merged
@vscodenpa vscodenpa added the unreleased Patch has not yet been released in VS Code Insiders label Mar 21, 2023
@vscodenpa vscodenpa added this to the March 2023 milestone Mar 21, 2023
@vscodenpa vscodenpa added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Mar 21, 2023
@amunger amunger mentioned this issue Mar 21, 2023
Open
@rzhao271 rzhao271 added the verified Verification succeeded label Mar 22, 2023
@github-actions github-actions bot locked and limited conversation to collaborators May 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rebornix rebornix

@amunger amunger

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders notebook-output verified Verification succeeded
Projects
None yet
Milestone
March 2023
Development

Successfully merging a pull request may close this issue.

fix the hover over the scrollbar for notebook outputs amunger/vscode
4 participants
@rebornix @amunger @rzhao271 @vscodenpa