Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Security by least privilege #177734

Closed
MartinMcCaulley opened this issue Mar 20, 2023 · 1 comment
Closed

Security by least privilege #177734

MartinMcCaulley opened this issue Mar 20, 2023 · 1 comment

Comments

@MartinMcCaulley
Copy link

Type: Bug

You should not be remembering terminal sessions. It is taking longer and longer for the bash terminal to restore itself. It is unnecessary and a security issue. Let .bashrc do the heavy lifting and stop trying to do too much in the vscode shell.

VS Code version: Code 1.76.2 (ee2b180, 2023-03-14T17:55:54.936Z)
OS version: Windows_NT x64 10.0.22621
Modes:
Sandboxed: No
@Tyriar
Copy link
Member

Tyriar commented Mar 20, 2023

You can disable the terminal restoration features and shell integration. I believe the main slowdown actually came when we changed the process architecture to enable reconnection and prevent a crashed terminal proc from taking down VS Code. We'll be improving this soon in #175335

@Tyriar Tyriar closed this as completed Mar 20, 2023
@github-actions github-actions bot locked and limited conversation to collaborators May 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Tyriar @MartinMcCaulley