Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double scrollbars #177792

Closed
chrmarti opened this issue Mar 21, 2023 · 6 comments
Closed

Double scrollbars #177792

chrmarti opened this issue Mar 21, 2023 · 6 comments
Assignees
Labels
notebook-builtin-renderers Builtin notebook output renderers for HTML, JS and images under-discussion Issue is under discussion for relevance, priority, approach

Comments

@chrmarti
Copy link
Contributor

Testing #177719

The editor and the cells have scrollbars which is confusing to look at and difficult to use.

Maybe instead of adding scrollbars to cells, let them show a 'Show More' button at the bottom when the content grows too large and let that expand the cell to show all content? (Maybe then show a 'Show Less' button at the bottom of a fully expanded cell to go back.)

@Tyriar
Copy link
Member

Tyriar commented Mar 21, 2023

I also find it a little strange that we decided to go with a scrollable region here, but not for the actual editor. The UX of a scrollable region in a scrollable region is pretty bad, mouse wheel down in the gif below shows that scrolling down will get "caught" on an output cell:

Recording 2023-03-21 at 10 56 33

@rebornix rebornix added the under-discussion Issue is under discussion for relevance, priority, approach label Mar 21, 2023
@rebornix
Copy link
Member

Maybe instead of adding scrollbars to cells, let them show a 'Show More' button at the bottom when the content grows too large and let that expand the cell to show all content? (Maybe then show a 'Show Less' button at the bottom of a fully expanded cell to go back.)

@chrmarti @Tyriar thanks for the feedback. The original design is what you described, we don't show scrollable output at all but it's not how most Jupyter users use streaming and error outputs. They expect a scrollable output which contains enough text that they can search. That's why we experimented the scrollable output support and also considering making it the default experience.

@rebornix rebornix added the notebook-builtin-renderers Builtin notebook output renderers for HTML, JS and images label Mar 21, 2023
@Tyriar
Copy link
Member

Tyriar commented Mar 21, 2023

Ah ok. Could we instead collapse the output by default but when searching the document, search in the collapsed area and automatically expand it? Once find goes beyond that section, collapse again?

@amunger
Copy link
Contributor

amunger commented Mar 21, 2023

sounds like this request that we received pretty early on #174951, which I liked quite a bit.

That way we could have both view types easily available and reduce the drawbacks of having so many scrollable sub-regions

@chrmarti
Copy link
Contributor Author

#174951 sounds like it would still show double scrollbars. Couldn't these be avoided by having a button to go from capped to full output size? This would preserve the editor's behavior as a "single large document" that can be scrolled.

@amunger
Copy link
Contributor

amunger commented Mar 22, 2023

This was a very popular request, which is why it was implemented this way. Expanding to show the full output might look strange when the output is very large. We'll keep gathering feedback from users to try and improve though.

@amunger amunger closed this as not planned Won't fix, can't repro, duplicate, stale Mar 22, 2023
@github-actions github-actions bot locked and limited conversation to collaborators May 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
notebook-builtin-renderers Builtin notebook output renderers for HTML, JS and images under-discussion Issue is under discussion for relevance, priority, approach
Projects
None yet
Development

No branches or pull requests

4 participants