Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlighted quick input option is not announced #178163

Closed
connor4312 opened this issue Mar 23, 2023 · 7 comments
Closed

Highlighted quick input option is not announced #178163

connor4312 opened this issue Mar 23, 2023 · 7 comments
Assignees

Comments

@connor4312
Copy link
Member

When typing in the text field, the number of results is announced by NVDA but not the highlighted option. This can be a productivity killer. I believe the announcement of the highlighted option is the most important piece of information while typing. the number of results is irrelevant at this point. It becomes important when the user starts to navigate with the arrow keys, and at that time the screen reader takes care of it.

Version: 1.77.0-insider (user setup)
Commit: 6fe3014
Date: 2023-03-23T10:21:45.873Z
Electron: 19.1.11
Chromium: 102.0.5005.196
Node.js: 16.14.2
V8: 10.2.154.26-electron.0
OS: Windows_NT x64 10.0.22621
Sandboxed: Yes

Originally posted by @rperez030 in #166920 (comment)

@connor4312
Copy link
Member Author

Following up during verification: when typing, there is no highlighted option. So I'm not entirely sure what the intended behavior is here.

@meganrogge
Copy link
Contributor

Following up during verification: when typing, there is no highlighted option. So I'm not entirely sure what the intended behavior is here.

This is as a result of the fix for #166920. It's a tricky dilemma

@rperez030
Copy link
Contributor

Personally, I would strongly suggest to roll-back the fix until a more global solution becomes possible. between that and the unnecessary announcement of results while typing, the experience of using the command palette can be perceived as significantly poorer for screen reader users. Being able to simply start typing a command and press Enter to execute is something I find very powerful as a keyboard user. It is possible that this fix is also affecting other areas in the editor. For example, when using CTRL +G to navigate to a specific line, it is no longer possible to type the number and press Enter to confirm, and this only happens when screen reader mode is enabled.

@meganrogge
Copy link
Contributor

meganrogge commented Mar 23, 2023

@rperez030 I agree with your concerns and created this #177476 related to them.

Imo, we should have a setting for this

@TylerLeonhardt
Copy link
Member

TylerLeonhardt commented Mar 23, 2023

We can't have a setting if that behavior is unaccessible and the only reason it is different in the first place is because the non-accessibility mode experience is not accessible.

The only solution forward is to make they non-accessibility mode experience accessible... but it is unclear if the platform has what we need to accomplish this.

@meganrogge
Copy link
Contributor

The definition of accessible is different depending on the user's needs though @TylerLeonhardt

@TylerLeonhardt
Copy link
Member

I have captured the "try using something other than aria-activedecendant here: #176081

Let's have that issue be the center point of what this should all look like.

@github-actions github-actions bot locked and limited conversation to collaborators May 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants