Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance regression in require #178559

Closed
bpasero opened this issue Mar 29, 2023 · 3 comments · Fixed by #178558
Closed

Performance regression in require #178559

bpasero opened this issue Mar 29, 2023 · 3 comments · Fixed by #178558
Assignees
@bpasero
Labels
candidate Issue identified as probable candidate for fixing in the next release perf-startup verified Verification succeeded
Milestone
March 2023

Comments

@bpasero
Copy link
Member

bpasero commented Mar 29, 2023

Embedding unicode characters into our sources has shown a slowdown in require performance.
@bpasero bpasero added candidate Issue identified as probable candidate for fixing in the next release perf-startup labels Mar 29, 2023
@bpasero bpasero added this to the March 2023 milestone Mar 29, 2023
@bpasero bpasero self-assigned this Mar 29, 2023
@bpasero bpasero mentioned this issue Mar 29, 2023
Merged
@bpasero bpasero linked a pull request Mar 29, 2023 that will close this issue
perf - do not embedd unicode chars in sources #178558
Merged
@lorand-horvath
Copy link

lorand-horvath commented Mar 29, 2023 •
edited
Loading

@bpasero If this was the cause of #177257 , then it's a real good catch!

@bpasero
Copy link
Member Author

bpasero commented Mar 29, 2023

@lorand-horvath yes, it looks like the cause at least of the slowdown between March 9th and 10th around the require of workbench main.

@bpasero bpasero closed this as completed Mar 29, 2023
@sandy081 sandy081 added the verified Verification succeeded label Mar 29, 2023
@sandy081
Copy link
Member

Before: ellapsed: 810ms (fastest), 1294ms (slowest), 841ms (median)
After: ellapsed: 788ms (fastest), 1204ms (slowest), 805ms (median)

@github-actions github-actions bot locked and limited conversation to collaborators May 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
candidate Issue identified as probable candidate for fixing in the next release perf-startup verified Verification succeeded
Projects
None yet
Milestone
March 2023
Development

Successfully merging a pull request may close this issue.

perf - do not embedd unicode chars in sources microsoft/vscode
3 participants
@bpasero @sandy081 @lorand-horvath