Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

javascript syntax highlighting breaks when using template literals #17931

Closed
benvds opened this issue Dec 30, 2016 · 3 comments
Closed

javascript syntax highlighting breaks when using template literals #17931

benvds opened this issue Dec 30, 2016 · 3 comments
Assignees
Labels
javascript JavaScript support issues languages-basic Basic language support issues

Comments

@benvds
Copy link

benvds commented Dec 30, 2016

  • VSCode Version: 1.8.1
  • OS Version: macOS 10.12.2

Steps to Reproduce:

  1. Open new editor, set syntax language to javascript
  2. Code example that breaks:
const apiKey = 'foo';
const keyName = `filters[${apiKey}][]`;

// it's all fine
let subject = { [keyName]: checked };

// syntax highlighting ok
let breakMe = { [`filters[${apiKey}][]`]: 'bar' };

// template literal without let breaks syntax highlighting
breakMe = { [`filters[${apiKey}][]`]: 'bar' };
//                                ^- syntax highlighting breaks here

console.log('syntax broken here as well');

example

@rebornix
Copy link
Member

Dup of #13166

@mjbvz mjbvz assigned waderyan and mjbvz and unassigned waderyan Jan 3, 2017
@mjbvz mjbvz added javascript JavaScript support issues languages-basic Basic language support issues labels Jan 3, 2017
@mjbvz
Copy link
Collaborator

mjbvz commented Jan 3, 2017

This seems to be fixed in VSCode 1.9 insiders. @benvds, please give 1.9 insiders a try and let me know if you still see this issue.

Thanks

@mjbvz mjbvz closed this as completed Jan 3, 2017
@benvds
Copy link
Author

benvds commented Jan 4, 2017

@mjbvz seems to work now, thx!

example

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
javascript JavaScript support issues languages-basic Basic language support issues
Projects
None yet
Development

No branches or pull requests

4 participants