Test: New Default Theme

[aeschli]

Test for #179688

• AnyOS @paulacamargo25
• AnyOS @aiday-mar

Complexity: 4

Create Issue

---

We now ship with the new (Experimental*) Themes as Default. Name to change @daviddossett.

• new users will get the new Dark theme as default
• existing user that did not have a theme in their user settings will automatically get the new dark theme as default, but with a info dialog (notification)
• existing users that has one of the old default themes in their settings will get a dialog that proposes to switch (no automatic setting changes)

Desktop

• run vs code from an new user data dir (or a new profile)
• verify that VS Code comes up in the new Default Dark+ Experimental Theme
  • Check that the settings say that
  • Check that there's no color flickering when starting up. In particular the activity bar and the status bar should get the correct color right away

Web:

• run insiders.vscode.dev in a private window
  • verify that VS Code comes up in the new Default Dark+ Experimental Theme
  • Check that there's no color flickering when starting up. In particular the activity bar and the status bar should get the correct color right away

Desktop

• run a 1.77 vscode insiders on a new-user-data dir. It will show the old Dark+ theme. On shutdown it will persist these colors for a quick startup
• run the latest insiders (1.78) on that data dir
  • verify that the theme switches to the new Default Dark+ Experimental Theme
  • verify that there's a dialog that tells you about the automatic switch
  • there will be color changes while starting up, but only once

Desktop:

• run a 1.77 vscode insiders on a new-user-data dir. Switch to the Light+ theme. This will make a change to the settings. Close VS Code.

• run the latest insiders (1.78) on that data dir

  • verify that the theme does not automatically switch as this would involve changing the user settings
  • verify that there's a dialog that tells you about the new theme and asks you if you want to switch

[aiday-mar]

Hi @aeschli, I downloaded VS Code insiders 1.77.0 from the builds page, opened it. It was using the default dark theme. I clicked on restart to update. After the update, the VS Code instance shows it is on version 1.78.0, the new theme is used but I do not see a modal dialog popping up which would inform me of the theme change. I am wondering if perhaps I am testing incorrectly? You mention that the VS Code instance needs to be closed, so I suppose, that this might be the reason I don't see the dialog? The following gif shows my testing:

Update: I also tried closing the VS Code instance after installation of 1.77.0, and test from the default profile, not a test profile. The pop-up was not appearing.

Screen.Recording.2023-04-25.at.15.13.10.mov

[aeschli]

@aiday-mar Thanks for the great video. Yes, you should see a dialog here. I'll have a look.
When you started 1.77.0, did you had existing user data? Can you clear it ($HOME/Library/Application Support/Code - Insiders/User) or alternatively use a profile? We remember that the dialog has been shown in the storage.

[aeschli]

I tested again on the Mac and all works if the user storage and settings are deleted before running 1.77.

[aiday-mar]

By removing the User directory, it was verified the modal dialog appears