Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weird movement in Jupyter Notebooks while viewing images. #181695

Closed
livan3li opened this issue May 6, 2023 · 9 comments · Fixed by #184624
Closed

Weird movement in Jupyter Notebooks while viewing images. #181695

livan3li opened this issue May 6, 2023 · 9 comments · Fixed by #184624
Assignees
Labels
author-verification-requested Issues potentially verifiable by issue author bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone

Comments

@livan3li
Copy link

livan3li commented May 6, 2023

Does this issue occur when all extensions are disabled?: Yes

Version: 1.78.0 (user setup) Commit: 252e5463d60e63238250799aef7375787f68b4ee Date: 2023-05-03T20:09:00.748Z Electron: 22.4.8 Chromium: 108.0.5359.215 Node.js: 16.17.1 V8: 10.8.168.25-electron.0 OS: Windows_NT x64 10.0.19045 Sandboxed: No

I've reported a bug related jupyter notebook before here. After new release of vs code this below bug happens.

Steps to Reproduce:

img1408-Code-.Mi-580.mp4
  1. Open a Jupyter notebook file that contains some images.
  2. Try to view images and see what happens.
@livan3li livan3li changed the title Weird movement and refreshing in Jupyter Notebooks while viewing images. Weird movement in Jupyter Notebooks while viewing images. May 6, 2023
@rebornix rebornix added notebook-builtin-renderers bug Issue identified by VS Code Team member as probable bug labels May 9, 2023
@rebornix rebornix added this to the May 2023 milestone May 9, 2023
@amunger
Copy link
Contributor

amunger commented May 31, 2023

I'm not seeing this repro
@livan3li - can you try disabling all extensions and opening that same notebook to see if it still repros?
Also check which renderer is being used for the image by selecting 'change presentation' in the output menu
image

@amunger amunger added the info-needed Issue requires more information from poster label May 31, 2023
@amunger amunger modified the milestones: May 2023, June 2023 May 31, 2023
@livan3li
Copy link
Author

livan3li commented Jun 2, 2023

@amunger I've provided info about you asked in the video.

  1. All extensions are disabled
  2. It was using 1. as seen in the image and video.
  3. I tried other renderer as well to show difference.
  4. And another issue is; VS Code is scrolling down own its own when notebook is opened first time and loading of output started. It can be observed below in end of video as well. I cannot hold the page and have to scroll back by myself.

image

Rnamz4y2zf.mp4

@amunger amunger removed the info-needed Issue requires more information from poster label Jun 2, 2023
@amunger
Copy link
Contributor

amunger commented Jun 2, 2023

How many images are you displaying there? (I still don't see it with 500, though perf takes a big hit)
Does it repro with a smaller number of images? Like just displaying the same image 10 times.
Do you know if all the images are being displayed? I see some suspicious collapsed borders in between a few.
Can you try profile: create temporary profile and reloading to check if there's a setting causing this? (profile: switch profile to default to switch back)

@livan3li
Copy link
Author

livan3li commented Jun 3, 2023

@amunger Alright, I have tried the way you told me and created new profile and didnt install anything at all. But it seems that doesnt change.

I dont have a notebook that have few images. The notebook have 618 images as it could be seen in the video before images output says that 1/618, 2/618 .... 618/618. Those are the images is saved in storage after that they are being displayed.

As far as i noticed those movements only occurs when notebook is being loaded. Because if load finishes that movement seem to stop as well.

Another thing is there is something wrong about loading process as it could be seen in the video. I especially didnt use mouse's wheel not to confuse you, i only used scroll bar on the right.

VS Code stops loading/showing images after some point untill i scroll down bottom and if i come back it suddenly appears.

And i wanted to show how google colab loads notebook in the browser.

Colab.mp4
vs_code.mp4

@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jun 8, 2023
@connor4312 connor4312 added verified Verification succeeded verification-steps-needed Steps to verify are needed for verification author-verification-requested Issues potentially verifiable by issue author and removed verified Verification succeeded labels Jun 28, 2023
@vscodenpa
Copy link

This bug has been fixed in the latest release of VS Code Insiders!

@livan3li, you can help us out by commenting /verified if things are now working as expected.

If things still don't seem right, please ensure you're on version 4649b53 of Insiders (today's or later - you can use Help: About in the command palette to check), and leave a comment letting us know what isn't working as expected.

Happy Coding!

@connor4312
Copy link
Member

@amunger are there verification steps for this?

@amunger
Copy link
Contributor

amunger commented Jun 28, 2023

verification steps

  1. create a notebook and put a small image in your local workspace
  2. add a cell with the code:
from IPython.display import display, Image

for i in range(550):
    display(Image('smallImage.jpeg'))
  1. run the cell and wait for completion, (finished for me in a few seconds)
  2. save, close, and re-open the notebook

the images might take a bit to all render, but they shouldn't bump up and down once they are visible

@amunger amunger removed the verification-steps-needed Steps to verify are needed for verification label Jun 28, 2023
@connor4312 connor4312 added the verified Verification succeeded label Jun 28, 2023
@livan3li
Copy link
Author

livan3li commented Jun 29, 2023

@amunger Alright, I have tried the way you told me and created new profile and didnt install anything at all. But it seems that doesnt change.

I dont have a notebook that have few images. The notebook have 618 images as it could be seen in the video before images output says that 1/618, 2/618 .... 618/618. Those are the images is saved in storage after that they are being displayed.

As far as i noticed those movements only occurs when notebook is being loaded. Because if load finishes that movement seem to stop as well.

Another thing is there is something wrong about loading process as it could be seen in the video. I especially didnt use mouse's wheel not to confuse you, i only used scroll bar on the right.

VS Code stops loading/showing images after some point untill i scroll down bottom and if i come back it suddenly appears.

And i wanted to show how google colab loads notebook in the browser.

Colab.mp4
vs_code.mp4

@amunger Same bug (bumping up and down) still persists for me.
Another thing is loading of images are stuck some point and it's fixed if i scroll down to bottom and come back. I showed and explained the bug which was in vs_code.mp4 video and duration between 00:42-1:20.

Version: 1.79.2 (user setup) Commit: 695af097c7bd098fbf017ce3ac85e09bbc5dda06 Date: 2023-06-14T08:57:04.379Z Electron: 22.5.7 Chromium: 108.0.5359.215 Node.js: 16.17.1 V8: 10.8.168.25-electron.0 OS: Windows_NT x64 10.0.19045

@connor4312
Copy link
Member

This fix is only on VS Code Insiders right now. It looks like you're still using the stable version.

@github-actions github-actions bot locked and limited conversation to collaborators Jul 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
author-verification-requested Issues potentially verifiable by issue author bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants