Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add isProposedApiEnabled check for env var scope #182966

Closed
Tracked by #20822
Tyriar opened this issue May 19, 2023 · 5 comments · Fixed by #183255
Closed
Tracked by #20822

Add isProposedApiEnabled check for env var scope #182966

Tyriar opened this issue May 19, 2023 · 5 comments · Fixed by #183255
Assignees
Labels
api bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal-process Problems launching processes, managing ptys, exiting, process leaks, etc. verified Verification succeeded
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented May 19, 2023

It's used in #182883, this would be easiest after that's merged.

@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug api terminal-process Problems launching processes, managing ptys, exiting, process leaks, etc. labels May 19, 2023
@Tyriar Tyriar added this to the May 2023 milestone May 19, 2023
@karrtikr
Copy link
Contributor

@karrtikr
Copy link
Contributor

I wish instead of explicitly checking whether proposed API is enabled in package.json in the implementation, we could check it when checking distro for whether an extension is allowed a proposal instead.

@Tyriar
Copy link
Member Author

Tyriar commented May 23, 2023

@karrtikr the list of allowed extensions is not available in code - oss though on local or in CI

@karrtikr
Copy link
Contributor

That's fair but do we really need to check in code - oss when developing? I would think distro is being tested out in the final build that's published.

@Tyriar
Copy link
Member Author

Tyriar commented May 23, 2023

@karrtikr not my area but being strict is good for proposals and it's good to align oss with the product in areas like this. Consider a fork of VS Code that does not have the check, extensions could use the proposals without warning which could lead to easy breakages.

@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels May 24, 2023
@Tyriar Tyriar added the verified Verification succeeded label May 31, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jul 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal-process Problems launching processes, managing ptys, exiting, process leaks, etc. verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants