Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some Unit Test Problems #183506

Closed
yiliang114 opened this issue May 26, 2023 · 2 comments
Closed

Some Unit Test Problems #183506

yiliang114 opened this issue May 26, 2023 · 2 comments
Assignees
Labels
engineering VS Code - Build / issue tracking / etc.

Comments

@yiliang114
Copy link
Contributor

yiliang114 commented May 26, 2023

Does this issue occur when all extensions are disabled?: Yes

  • VS Code Version: latest vscode.dev or Version: 1.78.0 (Universal)

Version: 1.78.0 (Universal)
Commit: 252e546
Date: 2023-05-03T20:11:00.813Z
Electron: 22.4.8
Chromium: 108.0.5359.215
Node.js: 16.17.1
V8: 10.8.168.25-electron.0
OS: Darwin x64 21.3.0
Sandboxed: Yes

  • OS Version: 12.2.1 (21D62)

Steps to Reproduce:

  1. Clone https://github.com/microsoft/vscode
  2. Use Cmd + shift + p to build vscode.

Case 1:

  1. Use yarn test-browser --browser chromium --glob vs/**/**.test.ts to run unit test.
  2. Then You will find that the unit test executes all the test files instead of the glob match specified.

Case 2:

  1. Use yarn test-browser --browser chromium --glob vs/**/**.test.ts --debug to run unit test.
  2. There will be a browser flash, but I found that the loader.js is loaded repeatedly in renderer.html, Ideally, what version of the file to load should be determined according to the parameters, not all of them, otherwise the browser will report an error.

Case 3:

  1. Use yarn test-browser --browser chromium --glob src/vs/**/**.test.ts --debug to run unit test.
  2. An error has occurred: zsh: no matches found: vs/**/**.test.ts. Because the path prefix and suffix are not processed in glob mode.

image

@connor4312
Copy link
Member

Fixed 1/2 in #199979

3 is your shell trying to expand the glob pattern -- quote the pattern to avoid this

@connor4312 connor4312 added the engineering VS Code - Build / issue tracking / etc. label Dec 4, 2023
@connor4312
Copy link
Member

This has since been fixed

@microsoft microsoft locked and limited conversation to collaborators Jun 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
engineering VS Code - Build / issue tracking / etc.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants