Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tunnel service runs after removing the application on macOS #183824

Closed
deepak1556 opened this issue May 30, 2023 · 2 comments
Closed

tunnel service runs after removing the application on macOS #183824

deepak1556 opened this issue May 30, 2023 · 2 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug remote-tunnel verified Verification succeeded
Milestone

Comments

@deepak1556
Copy link
Collaborator

Testing #183700

  • After starting the tunnel service, move the application to trash (there is no uninstall process on macOS)
  • Verify code-insiders tunnel status results in command not found: code-insiders
  • Check activity monitor and see code-insiders-tunnel is running out of ~/.Trash/Visual Studio Code - Insiders.app/Contents/Resources/app/bin/code-tunnel-insiders
@connor4312
Copy link
Member

I can't repro this -- for me the tunnel successfully notices the application is deleted and shuts down after a few seconds

image

@deepak1556 if you can still reproduce this, can you please share the contents of ~/.vscode-insiders/cli/tunnel-service.log after doing it?

@connor4312 connor4312 added the info-needed Issue requires more information from poster label Jun 16, 2023
@deepak1556
Copy link
Collaborator Author

Unable to reproduce with latest insiders, seems to detect the deletion scenario.

[2023-06-20 01:00:12] info Shutting down: Executable no longer exists
[2023-06-20 01:00:12] trace Found token in keyring
[2023-06-20 01:00:12] debug [rpc.0] closing socket reader: eof
[2023-06-20 01:00:12] info [rpc.0] Disposed of connection to running server.
[2023-06-20 01:00:12] trace Tunnel closing gracefully
[2023-06-20 01:00:12] debug [russh::client] disconnected
[2023-06-20 01:00:12] debug [russh::client] drop session
[2023-06-20 01:00:12] debug [tunnels::connections::relay_tunnel_host] disconnected primary session after EOF
[2023-06-20 01:00:12] trace Tunnel closed with result: Ok(())
[2023-06-20 01:00:12] error [tunnels::connections::relay_tunnel_host] error handshaking session: EOF
[2023-06-20 01:00:12] debug [russh::client] drop handle
[2023-06-20 01:00:13] debug Tunnel shut down

@rzhao271 rzhao271 added verified Verification succeeded and removed info-needed Issue requires more information from poster labels Jun 28, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Aug 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug remote-tunnel verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants