Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When shell integration is disabled, the env changes are still applied #183838

Closed
meganrogge opened this issue May 30, 2023 · 2 comments
Closed

When shell integration is disabled, the env changes are still applied #183838

meganrogge opened this issue May 30, 2023 · 2 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s)

Comments

@meganrogge
Copy link
Contributor

meganrogge commented May 30, 2023

Testing #182970

I'm guessing that's because applyAtProcessCreation is true by default, but it's a bit surprising when I have explicitly only provided applyAtShellIntegration

collection.replace('FOO', 'REPLACED', { applyAtShellIntegration: true });
collection.append('APPENDING', 'appending', { applyAtShellIntegration: true })
collection.prepend('PREPENDING', 'prepending', { applyAtShellIntegration: true });

Screenshot 2023-05-30 at 11 57 00 AM

@meganrogge
Copy link
Contributor Author

it works (does not get applied) if I explicitly also provide applyAtProcessCreation: false, but I wish we could skip that step - related #183831

@Tyriar
Copy link
Member

Tyriar commented May 30, 2023

This was brought up by @karrtikr at #179476 (comment), we'll finalize the exact behavior in the api sync

@Tyriar Tyriar closed this as completed May 30, 2023
@Tyriar Tyriar added the *duplicate Issue identified as a duplicate of another issue(s) label May 30, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jul 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s)
Projects
None yet
Development

No branches or pull requests

2 participants