Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activating word highlighting across cells in VScode notebooks #184259

Closed
Himbeereis opened this issue Jun 4, 2023 · 2 comments · Fixed by #198467
Closed

Activating word highlighting across cells in VScode notebooks #184259

Himbeereis opened this issue Jun 4, 2023 · 2 comments · Fixed by #198467
Assignees
Labels
editor-highlight Editor selection/word highlight issues feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders notebook-cell-editor Bugs related to code editors in Notebooks (not intellisense / LS's) on-testplan
Milestone

Comments

@Himbeereis
Copy link

When I load an .ipynb file and I highlight a word in an individual cell, then VS Code highlights all occurrences of the word in this cell.
But it does not highlights the word across cells. Is there a way to configure it to do so?

@rebornix rebornix added feature-request Request for new features or functionality notebook-cell-editor Bugs related to code editors in Notebooks (not intellisense / LS's) labels Jun 5, 2023
@rebornix rebornix added this to the Backlog milestone Jun 5, 2023
@rebornix
Copy link
Member

Duplicate issue #91808

and it might be possible now with #185351

@Yoyokrazy
Copy link
Contributor

Talked with Joh re: some editor work that was working to solve a similar issue. He solved (#30014) for inline chat via linking wordHighlighters, but it was a somewhat limited fix, as the models had to be identical.

Current thoughts are to create a MultiDocumentHighlightProvider and then refactor a bit of the work within wordHighlighter such that computeOccurences returns a Map<URI, DocumentHighlights[]>. This would create a solution that would solve highlighting across all open editors, fixing split view highlighting, notebooks, inline chat, etc etc.

Part of the issue lies in not having a position when you are computing highlights for the non-primary model aka the non-active editor(s). A pure textual search would work but isn't the most performant. Food for thought.

@Yoyokrazy Yoyokrazy modified the milestones: October 2023, November 2023 Oct 24, 2023
@Yoyokrazy Yoyokrazy added editor-highlight Editor selection/word highlight issues and removed on-testplan labels Nov 7, 2023
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Nov 22, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jan 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
editor-highlight Editor selection/word highlight issues feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders notebook-cell-editor Bugs related to code editors in Notebooks (not intellisense / LS's) on-testplan
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants