Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot watch for file changes for files on disk root #1847

Closed
potasiyam opened this issue Jan 7, 2016 · 6 comments
Closed

Cannot watch for file changes for files on disk root #1847

potasiyam opened this issue Jan 7, 2016 · 6 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded

Comments

@potasiyam
Copy link

Code version: 0.10.6
OS: Windows 10 x64

I have noticed that if a file is open in code and the file is changed externally, there is no way to know about it until I try to save it. I feel that if the file on the disk and file opened on code is in same state it should automatically reflect the changes made on the disk. This is what every modern text editor do.
Here is how to reproduce it.

  • Create a text file.
  • Open the file in Sublime text, Bracket and Code. In this situation the file is blank in all 3 editors.
  • In Sublime text, write "Hello". Then save.
  • Switch to Bracket, You will see "Hello".
  • Switch to Code, you will see blank.
  • Now again switch to Bracket, write "Hello world". Then save.
  • Switch to Sublime text, You will see "Hello world".
  • Switch to Code, you will see blank.

In both cases Code should reflect the changes made on disk.

@bpasero
Copy link
Member

bpasero commented Jan 7, 2016

@potasiyam can you run "code --verbose" and open the dev tools console to see file events logged and retry and send the output here?

@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug info-needed Issue requires more information from poster labels Jan 7, 2016
@bpasero bpasero modified the milestones: Jan 2016, Backlog Jan 7, 2016
@potasiyam
Copy link
Author

Actually nothing appears in the console when the file is externally changed.
capture

@bpasero
Copy link
Member

bpasero commented Jan 11, 2016

I think in your case you opened just a file, can you try the same thing with opening its parent folder and see if then the updates happen? Also, is this G: drive something you created with SUBST or a real physical drive?

@potasiyam
Copy link
Author

Opening the parent folder solves it. I created a folder then put the file in there and opened the folder in code. Now it updates immediately with external changes.
My G: drive is a physical drive.
So it doesn't work with single files, right?

@bpasero
Copy link
Member

bpasero commented Jan 12, 2016

I can reproduce, this only seems to happen for files that are on the root of the disk: nodejs/node#4643

@bpasero bpasero added upstream Issue identified as 'upstream' component related (exists outside of VS Code) and removed info-needed Issue requires more information from poster labels Jan 12, 2016
@bpasero bpasero changed the title Opened file in Code is not updated immidietely when changed externally Cannot watch for file changes for files on disk root Jan 12, 2016
@bpasero bpasero modified the milestones: September 2016, Backlog Sep 16, 2016
@bpasero
Copy link
Member

bpasero commented Sep 19, 2016

This issue was fixed meanwhile in node.js and we updated to a newer Electron version.

@bpasero bpasero closed this as completed Sep 19, 2016
@octref octref added the verified Verification succeeded label Sep 29, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants