Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: NB toolbar Run All + Stop execution actions #186262

Closed
2 tasks done
Yoyokrazy opened this issue Jun 27, 2023 · 2 comments
Closed
2 tasks done

Test: NB toolbar Run All + Stop execution actions #186262

Yoyokrazy opened this issue Jun 27, 2023 · 2 comments

Comments

@Yoyokrazy
Copy link
Contributor

Yoyokrazy commented Jun 27, 2023

Refs: #184194

Complexity: 1

Create Issue


Summary:

There was previously a bug when executing notebook code using a kernel without an interrupt handler. After executing the Run All action, it would not hide, and the Stop Execution action would appear alongside.

Intended behavior is for the Stop Execution action to replace the Run All action.

Steps to Test:

  • Open a notebook, and select a kernel without an interrupt handler.
  • Execute multiple code cells, and ensure that Run All and Stop Execution do not appear side by side. Running a cell with a sleep in it makes this more visible.

Thanks so much for testing!

@vscodenpa vscodenpa added this to the June 2023 milestone Jun 27, 2023
@ghost ghost assigned deepak1556 and bamurtaugh Jun 27, 2023
@deepak1556 deepak1556 removed their assignment Jun 27, 2023
@deepak1556
Copy link
Collaborator

Using the kernel from https://marketplace.visualstudio.com/items?itemName=joyceerhl.vscode-pyodide and the following code with sleep didn't help to verify the issue

import time

print("Hello World!")
time.sleep(30)
print('Done!')

I ended up using examples from https://jupyterlite.readthedocs.io/en/latest/_static/lab/index.html to get long enough execution. Would be great if some notebook samples are provided with the test plan :)

@Yoyokrazy
Copy link
Contributor Author

I'll toss a notebook up now! Thanks for the feedback and testing 👍

@bamurtaugh bamurtaugh removed their assignment Jun 27, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Aug 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants