Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Could not get Accessibility View to work with extension contributed hovers #186296

Closed
isidorn opened this issue Jun 27, 2023 · 6 comments · Fixed by #188112
Closed

Could not get Accessibility View to work with extension contributed hovers #186296

isidorn opened this issue Jun 27, 2023 · 6 comments · Fixed by #188112
Assignees
@meganrogge
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone
July 2023

Comments

@isidorn
Copy link
Contributor

isidorn commented Jun 27, 2023

Testing #186214

  1. Install GitHub Pull Request extension. Open GitHub view on the side. Hover over an issue, and put focus in it
  2. Ctrl + F2 to open Accessibility View. Nothing happens 🐛

I could not get the Accessibility View to work with any hover. What am I missing here?
@meganrogge
Copy link
Contributor

Hm, any errors in the dev tools console?
https://github.com/microsoft/vscode/assets/29464607/4ee829a1-afd3-4217-b048-f9e51039bef0

@meganrogge meganrogge added the info-needed Issue requires more information from poster label Jun 27, 2023
@meganrogge
Copy link
Contributor

Yeah they're not working in the scm view for me

@meganrogge meganrogge added bug Issue identified by VS Code Team member as probable bug accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues and removed info-needed Issue requires more information from poster labels Jun 27, 2023
@meganrogge meganrogge added this to the July 2023 milestone Jun 27, 2023
@meganrogge meganrogge changed the title Could not get Accessibility View to work with hovers Could not get Accessibility View to work with extension contributed hovers Jun 27, 2023
@meganrogge meganrogge mentioned this issue Jul 17, 2023
Merged
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jul 17, 2023
@isidorn
Copy link
Contributor Author

isidorn commented Jul 25, 2023

This still does not work for me for the GitHub issues view.
@meganrogge can you reproduce with the GitHub issues view? You should just install the GH PR extension and you should get the issues view and you can try out this there. Thanks

@meganrogge
Copy link
Contributor

Here's what I see in the GH PR view - I'll try issues
https://github.com/microsoft/vscode/assets/29464607/037666b3-13ca-4656-9ed3-97c8a9b725e4

@meganrogge
Copy link
Contributor

meganrogge commented Jul 26, 2023 •
edited
Loading

it's also working for me in the github issues view - I'm using the keyboard shortcut of cmd + k + i. are you? also works for me if I hover and click.

issues.mov

@isidorn
Copy link
Contributor Author

isidorn commented Jul 27, 2023

Works now. I was doing something wrong. Thank you. Adding verified.

@isidorn isidorn added the verified Verification succeeded label Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@meganrogge meganrogge

Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Milestone
July 2023
Development

Successfully merging a pull request may close this issue.

get AccessibleView to work for extension contributed hovers microsoft/vscode
3 participants
@isidorn @meganrogge @vscodenpa