Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The “go to definition” link will be abnormal when the id is with "-" #18637

Closed
ghost opened this issue Jan 17, 2017 · 4 comments
Closed

The “go to definition” link will be abnormal when the id is with "-" #18637

ghost opened this issue Jan 17, 2017 · 4 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s) typescript Typescript support issues

Comments

@ghost
Copy link

ghost commented Jan 17, 2017

  • VSCode Version: 1.8.1
  • OS Version: Windows 10 1607

8

Steps to Reproduce:
1.Create a .ts file, define "vue-router" and input import * as Router from "vue-router";.
2.Move the mouse onto the "vue-router" as you press the "Ctrl".

The “go to definition” link will be abnormal, only "vue" or "router" turn blue.

@ghost
Copy link
Author

ghost commented Jan 17, 2017

Also it's abnormal when the id is with ""
9
When I click the blue link "vuex", the "./vuex/store" will be opened but not "vuex".

@dbaeumer dbaeumer added the typescript Typescript support issues label Jan 17, 2017
@mjbvz mjbvz self-assigned this Jan 17, 2017
@mjbvz
Copy link
Collaborator

mjbvz commented Jan 17, 2017

@LongQue Do you have any extensions installed? I don't think our builtin functionality provides links for TypeScript imports.

@mjbvz mjbvz added the info-needed Issue requires more information from poster label Jan 17, 2017
@ghost
Copy link
Author

ghost commented Jan 18, 2017

@mjbvz I don't think it's a problem caused by my extensions.

4 extensions installed

  • C/C++
  • C#
  • Python
  • Python for VSCode

It also appears in a .js file.
10
"vue-router" is defined in a .d.ts file.

@mjbvz
Copy link
Collaborator

mjbvz commented Jan 18, 2017

@LongQue Thanks, I'm able to repo this now.

After investigating, this looks like a duplicate of #10037. We need a new API on the VSCode side to define the range of a definition in the source document

@mjbvz mjbvz closed this as completed Jan 18, 2017
@mjbvz mjbvz added *duplicate Issue identified as a duplicate of another issue(s) and removed info-needed Issue requires more information from poster labels Jan 18, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s) typescript Typescript support issues
Projects
None yet
Development

No branches or pull requests

3 participants