Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Find Widget tab order #1869

Closed
1 task done
alexdima opened this issue Jan 8, 2016 · 0 comments
Closed
1 task done

Find Widget tab order #1869

alexdima opened this issue Jan 8, 2016 · 0 comments
Assignees
@pjmeyer
Labels
testplan-item
Milestone
Jan 2016

Comments

@alexdima
Copy link
Member

alexdima commented Jan 8, 2016

The find widget can be in 4 states, please check the tab order in all the 4 states:

no search string, replace hidden:
image
no search string, replace revealed:
image
with search string, replace hidden:
image
with search string, replace revealed:
image

Moreover, the Find in Selection toggle can be enabled or disabled based on current editor selection.

The nominal tab order (when everything is enabled) is the following:
image

Please check carefully with Tab and Shift+Tab as a lot of tricks are needed to implement this tab order (that is not the element order in the DOM)
@alexdima alexdima added this to the Jan 2016 milestone Jan 8, 2016
@egamma egamma mentioned this issue Jan 23, 2016
Closed
59 tasks
@pjmeyer pjmeyer self-assigned this Jan 26, 2016
@pjmeyer pjmeyer mentioned this issue Jan 26, 2016
Closed
@bpasero bpasero closed this as completed Jan 27, 2016
@egamma egamma mentioned this issue Feb 1, 2016
Closed
97 tasks
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@pjmeyer pjmeyer

Labels
testplan-item
Projects
None yet
Milestone
Jan 2016
Development

No branches or pull requests
3 participants
@bpasero @alexdima @pjmeyer