Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async Tokenization Error #186915

Closed
hediet opened this issue Jul 3, 2023 · 5 comments
Closed

Async Tokenization Error #186915

hediet opened this issue Jul 3, 2023 · 5 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug tokenization Text tokenization verified Verification succeeded
Milestone

Comments

@hediet
Copy link
Member

hediet commented Jul 3, 2023

chrome_cSj83ypc9l

Verification steps: See telemetry (and last message in this issue).

@hediet hediet added bug Issue identified by VS Code Team member as probable bug tokenization Text tokenization labels Jul 3, 2023
@hediet hediet added this to the July 2023 milestone Jul 3, 2023
@hediet hediet self-assigned this Jul 3, 2023
@hediet
Copy link
Member Author

hediet commented Jul 6, 2023

Idea: Put breakpoints into the webworker and try to cause unusual timing situations.
Idea: Change language.

@hediet
Copy link
Member Author

hediet commented Jul 21, 2023

Might be fixed by #188421 and #188818

@hediet hediet modified the milestones: July 2023, August 2023 Jul 27, 2023
@hediet
Copy link
Member Author

hediet commented Aug 14, 2023

This query returns 0 rows:

RawEventsVSCode
| where ApplicationVersion == "1.81.1"
| where EventName == "monacoworkbench/unhandlederror"
| where Properties.callstack has "applyStateStackDiff"

Thus assuming the error is fixed.

@hediet hediet closed this as not planned Won't fix, can't repro, duplicate, stale Aug 14, 2023
@hediet hediet closed this as completed Aug 14, 2023
@lszomoru
Copy link
Member

I reran the query and I see three entries in our telemetry, hence reopening the issue.

@lszomoru lszomoru reopened this Aug 31, 2023
@lszomoru lszomoru added the verification-found Issue verification failed label Aug 31, 2023
@hediet
Copy link
Member Author

hediet commented Aug 31, 2023

The reported errors are Perf sampling errors ("PerfSampleError: by <<renderer>> in pushFrame#main.js:1:11470"). Also, 3 rows might be caused by inconsistent data.

Compare this with the 3k events reported from insiders:

RawEventsVSCode
| where ApplicationVersion == "1.81.0-insider"
| where EventName == "monacoworkbench/unhandlederror"
| where Properties.callstack has "applyStateStackDiff"

@hediet hediet closed this as completed Aug 31, 2023
@lszomoru lszomoru added verified Verification succeeded and removed verification-found Issue verification failed labels Aug 31, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Oct 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug tokenization Text tokenization verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

2 participants