-
Notifications
You must be signed in to change notification settings - Fork 29.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a set of icons+colors for custom profiles #188972
Comments
Has this been implemented yet? It's showing as closed, and on the August 2023 milestone, but I haven't found it surfaced in 1.82.0-insider nor located a related PR. |
@gjsjohnmurray Not yet. This is just the design prep work. We'll probably implement this month. |
FYI the current list is not compatible with use in the terminal as key icons are missing like powershell, debian, ubuntu, etc. #171076 |
If we add all the |
What's the rationale for not opening up to all product icons? Somebody asked about this on SO: https://stackoverflow.com/q/77242748/11107541 |
Reopening so the concerns above get looked at, forcing a subset when there's a reference doc seems like we're just introducing an inconsistency. We want a general icon picker, not just one exclusively for profiles. |
Closing this as the original task has been completed. We should definitely share code for this for Terminals and support icon subsets. |
Created a new issue for the remaining work: #199964 |
This will help to distinguish between profiles.
The text was updated successfully, but these errors were encountered: