Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a set of icons+colors for custom profiles #188972

Closed
hbons opened this issue Jul 26, 2023 · 11 comments
Closed

Create a set of icons+colors for custom profiles #188972

hbons opened this issue Jul 26, 2023 · 11 comments
Assignees
Labels
icons-product Issues for in-product icons user-profiles User profile management ux User experience issues

Comments

@hbons
Copy link
Member

hbons commented Jul 26, 2023

This will help to distinguish between profiles.

@hbons hbons added this to the August 2023 milestone Jul 26, 2023
@hbons hbons self-assigned this Jul 26, 2023
@hbons
Copy link
Member Author

hbons commented Aug 21, 2023

@hbons hbons added ux User experience issues icons-product Issues for in-product icons user-profiles User profile management labels Aug 21, 2023
@hbons
Copy link
Member Author

hbons commented Aug 28, 2023

New proposal for profile colours.

image

Added magenta, cyan, brown, and two greys for variety.

Removed the dark blue/indigo as it doesn't provide enough contrast on dark backgrounds. Also removed purple because it looks too much like light purple.

@hbons
Copy link
Member Author

hbons commented Aug 28, 2023

Here's a subset of the codicons we can use for the initial set of profile icons. There are mostly everyday objects, and avoids abstract concepts/actions. Will add a couple more later for diversity, specially in the hardware and languages areas.
these icons names should have new links to them starting with profile-custom-*.

hardware/devices:
vm, server, record keys, device mobile, watch

languages:
ruby, python, html, code, react

project types:
window, library, extensions, terminal, beaker, package, cloud, book, globe, database, notebook

misc:
gift, send, briefcase, megaphone, comment, telescope, credit card, map, device camera, device camera video, unmute, law, graph line, heart, home, index, mortar board, rocket, magnet, lock, milestone, tag, pulse, radio tower, smiley, symbol event, squirrel, symbol color, mail, key, pie chart, organization, preview, wand, star empty, lightbulb, symbol ruler, dashboard, calendar, shield, flame, compass, paintcan, archive

image

@hbons hbons closed this as completed Aug 29, 2023
@gjsjohnmurray
Copy link
Contributor

Has this been implemented yet? It's showing as closed, and on the August 2023 milestone, but I haven't found it surfaced in 1.82.0-insider nor located a related PR.

@hbons
Copy link
Member Author

hbons commented Sep 4, 2023

@gjsjohnmurray Not yet. This is just the design prep work. We'll probably implement this month.

@Tyriar
Copy link
Member

Tyriar commented Sep 7, 2023

FYI the current list is not compatible with use in the terminal as key icons are missing like powershell, debian, ubuntu, etc. #171076

@Tyriar
Copy link
Member

Tyriar commented Sep 21, 2023

If we add all the terminal* codicons to this the list will be sufficient for use in the terminal (#171076). A good thing about the terminal is we don't need to worry too much about breaking existing users since they use codicon ids in the settings so their old selections will continue to work.

@starball5
Copy link

What's the rationale for not opening up to all product icons? Somebody asked about this on SO: https://stackoverflow.com/q/77242748/11107541

@Tyriar
Copy link
Member

Tyriar commented Oct 9, 2023

Reopening so the concerns above get looked at, forcing a subset when there's a reference doc seems like we're just introducing an inconsistency. We want a general icon picker, not just one exclusively for profiles.

@Tyriar Tyriar reopened this Oct 9, 2023
@hbons
Copy link
Member Author

hbons commented Dec 4, 2023

Closing this as the original task has been completed. We should definitely share code for this for Terminals and support icon subsets.

@Tyriar
Copy link
Member

Tyriar commented Dec 4, 2023

Created a new issue for the remaining work: #199964

@github-actions github-actions bot locked and limited conversation to collaborators Jan 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
icons-product Issues for in-product icons user-profiles User profile management ux User experience issues
Projects
None yet
Development

No branches or pull requests

5 participants