Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"X" action is no longer shown in the view #191586

Closed
sandy081 opened this issue Aug 29, 2023 · 5 comments
Closed

"X" action is no longer shown in the view #191586

sandy081 opened this issue Aug 29, 2023 · 5 comments
Assignees
Labels
*as-designed Described behavior is as designed

Comments

@sandy081
Copy link
Member

Testing #191346

Before:

Image

After pressing "x" action, I am not seeing this action any more. I was assuming this action is to close the view

Image

@meganrogge
Copy link
Contributor

meganrogge commented Aug 29, 2023

If you check the tooltip, you'll see that the action disables the accessible view aria hint, so it's as designed that it no longer shows once you've done that

@meganrogge meganrogge added the *as-designed Described behavior is as designed label Aug 29, 2023
@vscodenpa
Copy link

The described behavior is how it is expected to work. If you disagree, please explain what is expected and what is not in more detail. See also our issue reporting guidelines.

Happy Coding!

@vscodenpa vscodenpa closed this as not planned Won't fix, can't repro, duplicate, stale Aug 29, 2023
@meganrogge
Copy link
Contributor

the icon isn't very important here - @daviddossett do you have an idea for what we could use instead?

@daviddossett
Copy link
Contributor

Is this a toggle? Should it, in lieu of a more specific icon, use bell-slash to turn it off, and bell to turn it back on?

@meganrogge
Copy link
Contributor

meganrogge commented Aug 29, 2023

@daviddossett it is not a toggle because once a user knows how to open the accessible view, they won't want to hear the hint again / enable it again. bell-slash seems right 👍🏼

@github-actions github-actions bot locked and limited conversation to collaborators Oct 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*as-designed Described behavior is as designed
Projects
None yet
Development

No branches or pull requests

4 participants