Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notebooks are not dimming #191615

Open
bpasero opened this issue Aug 29, 2023 · 1 comment
Open

Notebooks are not dimming #191615

bpasero opened this issue Aug 29, 2023 · 1 comment
Assignees
@Tyriar
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug notebook
Milestone
Backlog

Comments

@bpasero
Copy link
Member

bpasero commented Aug 29, 2023

Testing #191527

Image
@Tyriar Tyriar added the bug Issue identified by VS Code Team member as probable bug label Aug 29, 2023
@Tyriar Tyriar added this to the August 2023 milestone Aug 29, 2023
@Tyriar
Copy link
Member

Tyriar commented Aug 29, 2023 •
edited
Loading

Similar to #189650, notebooks use a webview to isolate outside content. I don't see a way to hook this up using existing classes currently. This will need a new class or to use a hook to listen for notebook focus changes and apply that way, there may also be complications applying opacity to sub documents.

@Tyriar Tyriar modified the milestones: August 2023, Backlog Aug 29, 2023
@Tyriar Tyriar added accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues notebook labels Aug 29, 2023
@Tyriar Tyriar mentioned this issue Aug 30, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tyriar Tyriar

Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug notebook
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
2 participants
@bpasero @Tyriar