Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support unfocused dimming of all workbench components like output and debug console #191616

Open
bpasero opened this issue Aug 29, 2023 · 8 comments
Assignees
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues feature-request Request for new features or functionality
Milestone

Comments

@bpasero
Copy link
Member

bpasero commented Aug 29, 2023

Testing #191527

I find the choice of dimming just the terminal in the panel strange, why not dim the output pane or maybe debug console?

@Tyriar
Copy link
Member

Tyriar commented Aug 29, 2023

Let's discuss in #191610

@Tyriar Tyriar closed this as completed Aug 29, 2023
@Tyriar Tyriar added the *duplicate Issue identified as a duplicate of another issue(s) label Aug 29, 2023
@bpasero bpasero reopened this Aug 30, 2023
@bpasero bpasero removed the *duplicate Issue identified as a duplicate of another issue(s) label Aug 30, 2023
@bpasero
Copy link
Member Author

bpasero commented Aug 30, 2023

Having talked about this in the Zurich standup, there was pushback on why only terminals and editors, but e.g. not output or debug console was included. So I am reopening this for consideration.

@bpasero bpasero changed the title Why is terminal dimmed but not output? Unfocussed dimming is not supporting text components like output or debug console Aug 30, 2023
@Tyriar Tyriar changed the title Unfocussed dimming is not supporting text components like output or debug console Support unfocused dimming of all workbench components like output and debug console Aug 30, 2023
@Tyriar Tyriar added feature-request Request for new features or functionality accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues labels Aug 30, 2023
@Tyriar
Copy link
Member

Tyriar commented Aug 30, 2023

The plan is to add a .views: { viewId: boolean } setting but keep the default opinionated as terminals and editors, unless feedback from the community hints we should do otherwise.

@svipas
Copy link
Contributor

svipas commented Sep 15, 2023

@Tyriar would be awesome if we are able to control or at least when you're navigating in the sidebar with extensions like Git, GitLens you're seeing content in the editor with 1 opacity, because now it is hard to read even though I find this feature useful. But when working only with terminal & editor it is awesome, because it dims terminal and vice versa so I thought it would be cool to have view array list which should dim so we have control over this. Or maybe this will be improved in the future so that viewing search results, Git, etc. will not dim.

@Tyriar
Copy link
Member

Tyriar commented Sep 15, 2023

@svipas doesn't that kind of defeat the purpose of the feature as input will not be going into the editor if you have the sidebar focused?

@svipas
Copy link
Contributor

svipas commented Sep 15, 2023

That is true, but it is hard to view code changes when you're looking around from Git view and then editor is dimmed, you need to manually focus to have full opacity, in all other cases I found it valuable. If I'm viewing diff that means I need to see content I'm viewing with full opacity, but then I'm just typing commit message, focusing on terminal, etc. in that case it makes sense to have dimmed view. Anyways, I guess this is mostly personal thing, that's why it would be awesome if this could be under config so everybody could adapt it to their needs.

@Tyriar
Copy link
Member

Tyriar commented Sep 15, 2023

Ah I see, this is similar to the problem when searching too: #190102

@svipas
Copy link
Contributor

svipas commented Sep 15, 2023

Yep, that what I meant, if it is going to be "fixed" together with search that is very good, because I like this new feature 👏

@Tyriar Tyriar modified the milestones: September 2023, Backlog Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

3 participants