Error when trying to alt+F1 in terminal

[alexr00]

Testing #191345

1. Turn on screen reader accessibility mode.
2. Open the terminal and focus into it.
3. alt+F1.
4. Get a warning "Cannot read properties of undefined (reading 'getAriaLabel')"
5. Accessible view doesn't open.

[meganrogge]

/duplicate #191591

[meganrogge]

@alexr00 I cannot repro - could you pls provide the full error stack trace?

[alexr00]

I checked, there wasn't an error stack trace in the console.

[meganrogge]

Does this only happen in the terminal for you?

[meganrogge]

I'll try on Windows, maybe that's the difference

[meganrogge]

nope doesn't repro for me there either 😢

[alexr00]

Yes, only in the terminal. It happens 100% of the time in the terminal as far as I can tell.

[meganrogge]

I see what could lead to this, thanks

[alexr00]

I'm also trying to find where it's coming from.

[meganrogge]

pretty sure it's coming from here

vscode/src/vs/workbench/contrib/terminalContrib/accessibility/browser/terminalAccessibilityHelp.ts

Lines 60 to 63 in 2af3045

	const kb = this._keybindingService.lookupKeybindings(commandId);
	// Run recent command has multiple keybindings. lookupKeybinding just returns the first one regardless of the when context.
	// Thus, we have to check if accessibility mode is enabled to determine which keybinding to use.
	return this._accessibilityService.isScreenReaderOptimized() ? format(msg, kb[1].getAriaLabel()) : format(msg, kb[0].getAriaLabel());

and for some reason, lookupKeybindings finds two for me which is why I cannot repro whereas it's only finding one for you, so kb[1] is udf

[alexr00]

I've just reload, which I though I had already done at least once since encountering the issue, and now I can't repo. I'm not sure what would have changed here.