Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only show Open Accessible View when there is an accessible view to open #191663

Closed
andreamah opened this issue Aug 29, 2023 · 2 comments
Closed
Assignees
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug wont-fix
Milestone

Comments

@andreamah
Copy link
Contributor

Testing #191344

I'm not sure if you considered this already, but it would be nice to have the Open Accessible View in the command palette only when you're focused on something that supports it. When running the command in a random place, it just does nothing, which might be confusing to people who are trying to learn what the command does.

@meganrogge
Copy link
Contributor

We want it in the command palette for discoverability purposes, but I agree with you that a no-op could be confusing.

@meganrogge meganrogge added bug Issue identified by VS Code Team member as probable bug accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues labels Aug 29, 2023
@meganrogge meganrogge added this to the August 2023 milestone Aug 29, 2023
@meganrogge
Copy link
Contributor

This would be involved to fix because currently, we don't have a concept of focusedItemWithAccessibleView. We might have this one day when there's an audio cue played to indicate that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug wont-fix
Projects
None yet
Development

No branches or pull requests

2 participants