Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Description for the setting workbench.view.dimUnfocused.enabled does not adhere to the sentence pattern used by other settings. #191676

Closed
bhavyaus opened this issue Aug 29, 2023 · 2 comments
Assignees
Labels
info-needed Issue requires more information from poster

Comments

@bhavyaus
Copy link
Collaborator

Testing #191527

Nit:
Screenshot 2023-08-29 at 10 56 55 AM

The sentence feels incomplete.

@Tyriar
Copy link
Member

Tyriar commented Aug 29, 2023

A recent PR changed this, any comments on the new text?

Whether to dim unfocused editors and terminals, which makes it more clear where typed input will go to. This works with the majority of editors with the notable exceptions of those that utilize iframes like notebooks and extension webview editors.

description: localize('dimUnfocusedEnabled', 'Whether to dim unfocused editors and terminals, which makes it more clear where typed input will go to. This works with the majority of editors with the notable exceptions of those that utilize iframes like notebooks and extension webview editors.'),

@Tyriar Tyriar added the info-needed Issue requires more information from poster label Aug 29, 2023
@VSCodeTriageBot
Copy link
Collaborator

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.

Happy Coding!

@VSCodeTriageBot VSCodeTriageBot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 6, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Oct 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
info-needed Issue requires more information from poster
Projects
None yet
Development

No branches or pull requests

3 participants