New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terminal: some tokens not light theme aware? #19191

Closed

bpasero opened this issue Jan 24, 2017 · 1 comment

Assignees

Labels

Member

bpasero commented Jan 24, 2017

Refs: #19071

I am using the light theme and the results from npm are sometimes shown in black, which looks bad in this theme:

bpasero assigned Tyriar

Member

Tyriar commented Jan 24, 2017

It's like that because npm is saying print yellow on black background. Looks better on a dark terminal:

Nothing we can do other than tweak the colors, which then may cause more contrast issues for yellow on light.

Tyriar closed this as completed

Tyriar added the *as-designed label

vscodebot bot locked and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.