Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terminal should inherit fontFamily and fontSize from editor #19265

Closed
dbaeumer opened this issue Jan 24, 2017 · 1 comment
Closed

Terminal should inherit fontFamily and fontSize from editor #19265

dbaeumer opened this issue Jan 24, 2017 · 1 comment
Assignees
@Tyriar
Labels
*as-designed Described behavior is as designed terminal Integrated terminal issues

Comments

@dbaeumer
Copy link
Member

Test: #19071

  • VSCode Version: 1.9
  • OS Version: Windows

Steps to Reproduce:

  1. Have the following settings
	"editor.fontFamily": "hack",
	"editor.fontSize": 13,
  1. Open the terminal

The fontSize seems to be 14. The font is not fully clear to. Would be nice if the terminal inherits the settings from the editor.
@dbaeumer dbaeumer added the terminal Integrated terminal issues label Jan 24, 2017
@Tyriar
Copy link
Member

Tyriar commented Jan 24, 2017

It was in 1.7.0 but I removed it since it was weird that the terminal was scaling with the editor when it was part of the workbench (when output, debug console, problem, etc. don't).

@Tyriar Tyriar closed this as completed Jan 24, 2017
@Tyriar Tyriar added the *as-designed Described behavior is as designed label Jan 24, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
*as-designed Described behavior is as designed terminal Integrated terminal issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dbaeumer @Tyriar