Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terminal: Invisible text is visible in the DOM renderer #192666

Closed
Tyriar opened this issue Sep 9, 2023 · 0 comments · Fixed by #192803
Closed

Terminal: Invisible text is visible in the DOM renderer #192666

Tyriar opened this issue Sep 9, 2023 · 0 comments · Fixed by #192803
Assignees
@Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal-rendering upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-fixed The underlying upstream issue has been fixed upstream-issue-linked This is an upstream issue that has been reported upstream verified Verification succeeded
Milestone
September 2023

Comments

@Tyriar
Copy link
Member

Tyriar commented Sep 9, 2023

Upstream: xtermjs/xterm.js#4758

Repro:

  1. On Linux/macOS/WSL
  2. Run echo -e '\x1b[8minvisible', it should not show invisible in the output
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug terminal-rendering upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-linked This is an upstream issue that has been reported upstream upstream-issue-fixed The underlying upstream issue has been fixed labels Sep 9, 2023
@Tyriar Tyriar added this to the September 2023 milestone Sep 9, 2023
@Tyriar Tyriar self-assigned this Sep 9, 2023
@Tyriar Tyriar mentioned this issue Sep 11, 2023
Merged
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Sep 11, 2023
@justschen justschen added the verified Verification succeeded label Sep 27, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Oct 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal-rendering upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-fixed The underlying upstream issue has been fixed upstream-issue-linked This is an upstream issue that has been reported upstream verified Verification succeeded
Projects
None yet
Milestone
September 2023
Development

Successfully merging a pull request may close this issue.

xterm@5.4.0-beta.17 - get VO to annouce terminal output and more microsoft/vscode
3 participants
@Tyriar @justschen @vscodenpa