Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explore Electron.net API support in the utility process #192899

Closed
2 tasks done
deepak1556 opened this issue Sep 12, 2023 · 3 comments · Fixed by electron/electron#40017
Closed
2 tasks done

Explore Electron.net API support in the utility process #192899

deepak1556 opened this issue Sep 12, 2023 · 3 comments · Fixed by electron/electron#40017
Assignees
Labels
electron Issues and items related to Electron feature-request Request for new features or functionality network Network related issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) verification-needed Verification of issue is requested verified Verification succeeded

Comments

@deepak1556
Copy link
Collaborator

deepak1556 commented Sep 12, 2023

It would provide us with the possibility of using chromium network stack which has better support for proxies directly from the utility process. Currently chromium transfers URLLoaderFactories to renderer process which allows blink to make network requests directly from the network service without having the need to go through the browser process, we will try to follow the same principle in this exploration.

  • Validate the exploration using a simple prototype
  • Scaffold Electron.net for the utility process

Prototype Implementation:

Let's create a interface on the NodeService utility process which accepts a URLLoaderFactory from the browser process and uses it to create a URLLoader to issue simple http(s) requests and outputs the response to a file.

Consists of 3 components

  • Declaring a mojo interface to transfer the URLLoaderFactory
  • Defining the interface in the Utility Process
  • Invoking the interface from the Browser Process

/cc @devm33

@deepak1556 deepak1556 self-assigned this Sep 12, 2023
@deepak1556 deepak1556 added this to the September 2023 milestone Sep 12, 2023
@deepak1556 deepak1556 added feature-request Request for new features or functionality upstream Issue identified as 'upstream' component related (exists outside of VS Code) electron Issues and items related to Electron network Network related issues labels Sep 12, 2023
@ulugbekna ulugbekna modified the milestones: October 2023, November 2023 Oct 26, 2023
@deepak1556 deepak1556 modified the milestones: November 2023, December 2023 Nov 27, 2023
@deepak1556
Copy link
Collaborator Author

/fixedWith #202053

@deepak1556 deepak1556 added the verified Verification succeeded label Jan 24, 2024
@deepak1556
Copy link
Collaborator Author

Steps for verification:

  • Add the following setting "github.copilot.advanced": { "debug.useElectronFetcher": true }
  • Reload Window
  • Open Github Copilot Chat output panel and check for the following log FetcherService] Using Electron fetcher
  • Test that chat requests are fullfilled without any network issues.

@deepak1556 deepak1556 added verification-needed Verification of issue is requested and removed verified Verification succeeded labels Jan 24, 2024
@joaomoreno
Copy link
Member

image

@joaomoreno joaomoreno added the verified Verification succeeded label Jan 24, 2024
@aiday-mar aiday-mar added this to the December / January 2024 milestone Feb 6, 2024
@microsoft microsoft locked and limited conversation to collaborators Jun 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
electron Issues and items related to Electron feature-request Request for new features or functionality network Network related issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) verification-needed Verification of issue is requested verified Verification succeeded
Projects
Status: ✔️ Done / Deferred
Development

Successfully merging a pull request may close this issue.

4 participants