Some code actions are de-prioritized in codeActionGroups

[yue4u]

Does this issue occur when all extensions are disabled?: Yes

• VS Code Version: 1.82.0 8b617bd x64
• OS Version: Linux home 6.5.2-arch1-1

Steps to Reproduce:

1. Expand code action menu at any code which has both refactor and refactor.inline codeActions
2. Since the order of codeActionGroups in codeActionMenu.ts is hard coded, it de-prioritizes the refactor code action and put it to uncategorizedCodeActionGroup i.e. More Actions...

   vscode/src/vs/editor/contrib/codeAction/browser/codeActionMenu.ts

   Lines 24 to 33 in b201702

   	const codeActionGroups = Object.freeze<ActionGroup[]>([
   	{ kind: CodeActionKind.QuickFix, title: localize('codeAction.widget.id.quickfix', 'Quick Fix') },
   	{ kind: CodeActionKind.RefactorExtract, title: localize('codeAction.widget.id.extract', 'Extract'), icon: Codicon.wrench },
   	{ kind: CodeActionKind.RefactorInline, title: localize('codeAction.widget.id.inline', 'Inline'), icon: Codicon.wrench },
   	{ kind: CodeActionKind.RefactorRewrite, title: localize('codeAction.widget.id.convert', 'Rewrite'), icon: Codicon.wrench },
   	{ kind: CodeActionKind.RefactorMove, title: localize('codeAction.widget.id.move', 'Move'), icon: Codicon.wrench },
   	{ kind: CodeActionKind.SurroundWith, title: localize('codeAction.widget.id.surround', 'Surround With'), icon: Codicon.symbolSnippet },
   	{ kind: CodeActionKind.Source, title: localize('codeAction.widget.id.source', 'Source Action'), icon: Codicon.symbolFile },
   	uncategorizedCodeActionGroup,
   	]);

Related:

rust-lang/rust-analyzer#15364

Although rust-lang/rust-analyzer#14362 has tried to fix the order but it does not work with grouping without changes on vscode's side.

Possible Fix:

Cover all CodeActionKind in order in codeActionGroups

https://code.visualstudio.com/api/references/vscode-api#CodeActionKind

[vscodenpa]

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.82.2. Please try upgrading to the latest version and checking whether this issue remains.

Happy Coding!

[justschen]

This is intended since refactorings (and all code actions) in general are grouped into the categories - actions with just refactor as the CodeActionKind are too unspecific.

A workaround could be like this:

Here, we specify a refactor subset to be grouped, instead of the blanket CodeActionKind.Refactor type.

	context.subscriptions.push(vscode.languages.registerCodeActionsProvider(
		{ scheme: 'file' },
		{
			provideCodeActions(document, range, context, token) {
				const results = [
					new vscode.CodeAction("Foo", vscode.CodeActionKind.RefactorRewrite),
				];
				return results;
			},
		}
	));

Alternatively, in this specific case, since it's removing something, it could potentially be a Quick Fix and be contributed as such instead.