Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

focus cell output with ctrl+down does not visually select the output #194432

Closed
amunger opened this issue Sep 28, 2023 · 3 comments · Fixed by #194512
Closed

focus cell output with ctrl+down does not visually select the output #194432

amunger opened this issue Sep 28, 2023 · 3 comments · Fixed by #194512
Assignees
@amunger
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders notebook-output verified Verification succeeded
Milestone
October 2023

Comments

@amunger
Copy link
Contributor

amunger commented Sep 28, 2023

found testing for #111255 (comment)

  1. run a cell to get output
  2. press ctrl+down to focus the output
    🐛 visually, it looks like the cell container is focused.
@amunger amunger added bug Issue identified by VS Code Team member as probable bug notebook-output labels Sep 28, 2023
@amunger amunger self-assigned this Sep 28, 2023
@rohanshardha
Copy link

rohanshardha commented Sep 28, 2023 •
edited
Loading

in the insiders build of 1.83.0, NVDA 2023.2 does read the output but like @amunger said it doesn't visually focus it. Unlike NVDA JAWS 2023.2307 doesn't even read the output. And even pressing alt+F2 while using JAWS, accessible view is not even pulled up/JAWS doesn't do anything. While output focus issue is not found in version 1.81.1 with JAWS 2023.2307. Seems like VS Code bug.

@amunger amunger mentioned this issue Sep 29, 2023
Merged
@vscodenpa vscodenpa added the unreleased Patch has not yet been released in VS Code Insiders label Sep 29, 2023
@vscodenpa vscodenpa added this to the September 2023 milestone Sep 29, 2023
@bhavyaus bhavyaus modified the milestones: September 2023, October 2023 Sep 29, 2023
@vscodenpa vscodenpa added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Oct 4, 2023
@aiday-mar aiday-mar added verified Verification succeeded and removed verified Verification succeeded labels Oct 25, 2023
@aiday-mar
Copy link
Contributor

So this worked but with the keybindings command+control+arrowDown on Mac. Not sure if the keybinding you mentioned is the keybinding on another platform like windows?

@amunger
Copy link
Contributor Author

amunger commented Oct 25, 2023

yes sorry, didn't notice that mac keybinding was different

primary: KeyMod.CtrlCmd | KeyCode.DownArrow,
mac: { primary: KeyMod.WinCtrl | KeyMod.CtrlCmd | KeyCode.DownArrow, },

@amunger amunger added the verified Verification succeeded label Oct 25, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Nov 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@amunger amunger

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders notebook-output verified Verification succeeded
Projects
None yet
Milestone
October 2023
Development

Successfully merging a pull request may close this issue.

fix output focus fallback microsoft/vscode
5 participants
@amunger @bhavyaus @aiday-mar @rohanshardha @vscodenpa