Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow editors to shrink to only their tab sizes #194885

Closed
jonlepage opened this issue Oct 5, 2023 · 13 comments
Closed

Allow editors to shrink to only their tab sizes #194885

jonlepage opened this issue Oct 5, 2023 · 13 comments
Assignees
Labels
feature-request Request for new features or functionality workbench-tabs VS Code editor tab issues

Comments

@jonlepage
Copy link

jonlepage commented Oct 5, 2023

Thank you for the latest update, this seems to be heading in the right direction for tabs view organisation.
However, I have some issues with the compact mode.
The arrangement of the panels still seems too large!

I would like to be able to do away with this height and maybe keep only the Breadcrumbs visible.
The excessive margin is rather unnecessary and takes up space for no reason in the layout.
Would it be possible to make the compact mode more compact?


actual
image

expected : css edit

image


Version: 1.83.0 (user setup)
Commit: e7e0370
Date: 2023-10-03T16:12:16.321Z
Electron: 25.8.4
ElectronBuildId: 24154031
Chromium: 114.0.5735.289
Node.js: 18.15.0
V8: 11.4.183.29-electron.0
OS: Windows_NT x64 10.0.19045
Steps to Reproduce:

@bpasero
Copy link
Member

bpasero commented Oct 5, 2023

I think related to / duplicate of #33607, though here specifically to only show breadcrumbs.

@djmisterjon so why don't you just disable tabs altogether then?

@bpasero bpasero added the info-needed Issue requires more information from poster label Oct 5, 2023
@jonlepage
Copy link
Author

I think related to / duplicate of #33607, though here specifically to only show breadcrumbs.

@djmisterjon so why don't you just disable tabs altogether then?

i tryed your suggestion but seem not work !
"workbench.editor.showTabs": false ?

all tabs organisation just gone !
image

@bpasero
Copy link
Member

bpasero commented Oct 5, 2023

@djmisterjon then I probably misunderstood your ask, can you phrase in simple terms how it should behave?

@jonlepage
Copy link
Author

@djmisterjon then I probably misunderstood your ask, can you phrase in simple terms how it should behave?

oki np, i will also make a gif tonight thanks for your time

@bpasero
Copy link
Member

bpasero commented Oct 5, 2023

👍

@jonlepage
Copy link
Author

jonlepage commented Oct 6, 2023

👍

sorry for the delay.
here, Sometimes it is said that a picture is worth a thousand words😊.
3qrtgqgf

As you can see towards the end of the GIF, the height contracts by css hack.
I haven't been able to find the location where the calculation is done in your source code, and I expected it to be done with CSS and flexbox !.
However, it seems that your calculations are done manually.
Therefore, I would like know if is possible to have a option that allows these sections to be compacted but keep only the Breadcrumbs visible like the end of the gif.

is this help to understand ?

edit

I want to provide a clarification and a brief justification for my ergonomic and organizational choice if is needed.
It is adapted and optimized for solo work on a large project with multiple workspaces for different contexts.
I typically work with two editors, each with several sections tailored to the workflow.

In a corporate setting , this is something that is rare to see due to task delegation.
We often restrict ourselves to having only a few tabs open based on specialized tasks and get abstraction of everything else.

But in solo working, i really need to maximize my workspace, in which I use the ctrl+P navigation approximately 80% of the time and 20% of the time i rely on visual navigation linked to a well-defined tab structure and organization.
So it why i need compact setting because i need keep my tabs organisation like this.

i add this just to clarify why i request this if is needed :)

@benibenj
Copy link
Contributor

benibenj commented Oct 6, 2023

Thanks for clarifying! We are currently working on a feature which would allow you to fully maximize the current editor group #194894. Would this be helpful for your case?
When toggled, it would hide all other editors, giving you the maximum space possible. When you want to switch editor group, you could toggle out of the maximize mode and pick a different editor group to maximize.

@jonlepage
Copy link
Author

jonlepage commented Oct 6, 2023

We are currently working on a feature which would allow you to fully maximize the current editor group #194894.

Thank you, yes it does seem to be related to my request , but not sure ,i cant see preview.
Do you think it will be possible to keep a preview of others tabs from other editor sections?
Because I like to have a view of the other sections tabs when I'm thinking or scan with my eyes.
In fact, i just find that the other sections use too much unnecessarily height and could be greatly reduced in the calculation of padding or margin.
I work on multi screen on 50-inch 4K screen, so it's not a problem to have a screen loaded with tabs with small fonts as long as I understand their organizational reasons.
I would even say it's a feature because it helps me a lot with my productivity

I just find it a pity to lose ~15% of height unnecessarily linked to the calculation of split between editor sections.

you could toggle out of the maximize mode and pick a different editor group to maximize.

so it will not automatically ? I will probably need to test it to see if it's better because I'm already a bit overwhelmed with many shortcuts

@bpasero bpasero added feature-request Request for new features or functionality workbench-tabs VS Code editor tab issues and removed info-needed Issue requires more information from poster labels Oct 7, 2023
@bpasero bpasero removed their assignment Oct 7, 2023
@bpasero bpasero changed the title window.density.editorTabHeight issue Allow editors to shrink to only their tab sizes Oct 7, 2023
@bpasero
Copy link
Member

bpasero commented Oct 7, 2023

I think I understood the request now: we keep a minimal size for editors that makes the editor groups have a minimal size. The ask here is to allow to make editor groups as small so that only the title area shows, but not the editor.

@vscodenpa vscodenpa added this to the Backlog Candidates milestone Oct 7, 2023
@vscodenpa
Copy link

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

@jonlepage
Copy link
Author

jonlepage commented Oct 7, 2023

I think I understood the request now: we keep a minimal size for editors that makes the editor groups have a minimal size. The ask here is to allow to make editor groups as small so that only the title area shows, but not the editor.

yes sry, i am not familiar with the VSCode API: the "section" was "editor groups"
or 'split-view-view' according to the official class name.
image

If you have time, can you provide me the link to the source code where this is implemented and computed ?
I would like to try making a MonkeyPatch because your vote system on GitHub is not very efficient.
This would involve regularly checking GitHub or promoting and pestering your colleagues to get votes, and I'm not a fan of that kind of social practice.

note: However, it would be great if you could centralize feature requests directly within VSCode. I would actively participate in voting for features. Currently, I vote about once every 3 or 4 months when I remember, and I'm being generous because most of time am not here for this !

thanks for your time

@vscodenpa
Copy link

This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

@vscodenpa
Copy link

🙁 In the last 60 days, this feature request has received less than 20 community upvotes and we closed it. Still a big Thank You to you for taking the time to create this issue! To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

@vscodenpa vscodenpa closed this as not planned Won't fix, can't repro, duplicate, stale Dec 7, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jan 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality workbench-tabs VS Code editor tab issues
Projects
None yet
Development

No branches or pull requests

4 participants