Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rootFolderNames & rootFolderNamesExpanded iconThemes definitions for root folders #195316

Closed
harbin1053020115 opened this issue Oct 11, 2023 · 8 comments
Assignees
Labels
feature-request Request for new features or functionality themes Color theme issues verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@harbin1053020115
Copy link
Contributor

harbin1053020115 commented Oct 11, 2023

We need to custom iconThemes of the workspace's root folders, we want to custom different iconThemes for each root folders according to the root folder's name:
image

@lramos15 lramos15 assigned aeschli and unassigned lramos15 Oct 11, 2023
@aeschli aeschli added this to the October 2023 milestone Oct 12, 2023
@aeschli aeschli added feature-request Request for new features or functionality themes Color theme issues labels Oct 12, 2023
@aeschli
Copy link
Contributor

aeschli commented Oct 16, 2023

fixed by #195319

@aeschli aeschli closed this as completed Oct 16, 2023
@aeschli aeschli added the verification-needed Verification of issue is requested label Oct 23, 2023
@aeschli
Copy link
Contributor

aeschli commented Oct 23, 2023

To verify:

@andreamah andreamah added verified Verification succeeded and removed verified Verification succeeded labels Oct 24, 2023
@DonJayamanne
Copy link
Contributor

Gave it a good crack, but unable to get things working.
Hopefully someone else will have better luck

@joaomoreno
Copy link
Member

Gave it a good crack, but unable to get things working. Hopefully someone else will have better luck

@DonJayamanne, can you provide @aeschli with details where you got stuck, so he knows how to improve the verification steps next time? Thanks.

@aeschli
Copy link
Contributor

aeschli commented Oct 25, 2023

Sorry for that @DonJayamanne, I'll have a look

@joaomoreno joaomoreno added the verified Verification succeeded label Oct 25, 2023
@joaomoreno
Copy link
Member

Got it to work. Needed something like this in an icon theme file, in which fakeproject would be the name of a root folder:

	"rootFolderNamesExpanded": {
		"fakeproject": "_file_light"
	},
	"rootFolderNames": {
		"fakeproject": "_folder_open_light"
	},

@aeschli was suggesting to just edit the extensions/theme-defaults/fileicons/vs_minimal-icon-theme.json in our repo, so one could run out of sources, pick the Minimal icon theme and see the changes.

@DonJayamanne
Copy link
Contributor

suggesting to just edit the extensions/theme-defaults/fileicons/vs_minimal-icon-theme.json in our repo,

Thats the only difference, I created a new extension.
Rest was the same.
Though its weird it didn't work, should have.

@aeschli
Copy link
Contributor

aeschli commented Oct 25, 2023

Oh, sorry, this should have been a real test plan item with complexity 3.

I came up with this repo to test it: https://github.com/aeschli/icon-theme-test2

It implements an icon theme with the new feature

  • clone the repo, open in VS Code
  • run the launch config. This opens on a test workspace with root folders and has the test file icon theme selected
  • Verify that the root folder called rootFolder1 has a different icon than rootFolder2 (it's just some random image)

@github-actions github-actions bot locked and limited conversation to collaborators Nov 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality themes Color theme issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

6 participants