Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

files are not excluded #196477

Closed
meganrogge opened this issue Oct 24, 2023 · 4 comments
Closed

files are not excluded #196477

meganrogge opened this issue Oct 24, 2023 · 4 comments
Assignees
Labels
file-watcher File watcher info-needed Issue requires more information from poster

Comments

@meganrogge
Copy link
Contributor

Testing #196194

I set:

	const fileWatcherOptions: vscode.FileSystemWatcherOptions = {		
		excludes: ['**/test/**'],		
	};

Created a folder, test, and this was logged:

/Users/meganrogge/VSCodeLaunchBug/test created. (at console.<anonymous> (/Users/meganrogge/Repos/vscode/vscode/out/vs/workbench/api/common/file:/Users/meganrogge/Repos/vscode/vscode/src/vs/workbench/api/common/extHostConsoleForwarder.ts:49:10))
@bpasero bpasero added the file-watcher File watcher label Oct 25, 2023
@bpasero
Copy link
Member

bpasero commented Oct 25, 2023

@meganrogge can you please share the full sample, including the call to create the file system watcher?

@bpasero bpasero added the info-needed Issue requires more information from poster label Oct 25, 2023
@bpasero
Copy link
Member

bpasero commented Oct 25, 2023

#196455 maybe related with a fix coming in only today.

@meganrogge
Copy link
Contributor Author

Yeah @bpasero mine was very similar setup to that one, so believe this can be closed as a duplicate

@meganrogge
Copy link
Contributor Author

It works for me in today's insider's

@github-actions github-actions bot locked and limited conversation to collaborators Dec 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
file-watcher File watcher info-needed Issue requires more information from poster
Projects
None yet
Development

No branches or pull requests

2 participants