-
Notifications
You must be signed in to change notification settings - Fork 29.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide a way to theme diff highlights #19735
Comments
I was just about to suggest this ;) Also, it would be nice to be able to customize the colors of the small vertical marks that appear for changes in the code (I'm not sure how they are called). It would be cool to be able to aesthetically match them with the theme colors :), and make sure they have sufficient contrast for darker themes, I guess. |
+1, people are asking for this for my theme |
I see this is closed, but can you provide more info about what theme creators need to do to provide coloring for diff? |
@akamud the public API is still being worked on so we don't have documentation for it yet. |
Right now themes cannot determine the colors of the git diff highlight colors meaning that if you want the theme to be readable you must select foreground colors that have sufficient contrast on both the green and the red colors.
This image has uses a comment foreground that looks great on the background but is completely unreadable on the light green diff highlight:
Ideally themes would be able to define this color since the color appears within the editor.
The text was updated successfully, but these errors were encountered: