-
Notifications
You must be signed in to change notification settings - Fork 29.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add action to show inline all diagnostics in file. #19749
Comments
@Krzysztof-Cieslak did you try the Problems view? It shows below the editor all problems. |
Yes, I know about Problems view. But I think that having inlined errors can be useful anyway. :) Changes in code are rather small so it's not adding any complexity etc, it's command so it's opt-in by users, it's providing same UI as existing diagnostics navigation, I don't see any drawbacks |
This is pretty much ready, If there is decision that feature proposal is accepted, I'll make PR. |
@jrieken FYI |
I like but there some technical challenges because of some shortcomings of the current implementation. The problem is that the zone widget with the little arrow on top can only be shown when its target line is rendered. Therefore it always reveals that line to enforce rendering. That's not a problem with how we use it today because goto error reveals the error anyways. However, it's a different story when showing all errors, the last one will always be revealed... In short, I'd happily review/guide a PR for this but it is a little bit of work... |
There is an extension in the marketplace called ErrorLens which does this: https://marketplace.visualstudio.com/items?itemName=PhilHindle.errorlens Might be useful until it's supported natively... |
Forked ErrorLens and made a few tweaks:
https://marketplace.visualstudio.com/items?itemName=usernamehw.errorlens |
This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation. Happy Coding! |
🙂 This feature request received a sufficient number of community upvotes and we moved it to our backlog. To learn more about how we handle feature requests, please see our documentation. Happy Coding! |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
For anyone who needs this feature, Errors Lens |
F8
andShift + F8
navigation between diagnostic is really nice but sometimes it would be useful to have nice view of all diagnostics in current file.Looks like it would be fairly simple to implement, just one additional editor action in https://github.com/Microsoft/vscode/blob/2a40036dbb34aac4f5aefbe999c21f2eaf76c59b/src/vs/editor/contrib/gotoError/browser/gotoError.ts, I could try implementing it if this feature idea is accepted.
The text was updated successfully, but these errors were encountered: