Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add action to show inline all diagnostics in file. #19749

Open
Krzysztof-Cieslak opened this issue Feb 2, 2017 · 13 comments
Open

Add action to show inline all diagnostics in file. #19749

Krzysztof-Cieslak opened this issue Feb 2, 2017 · 13 comments
Assignees
Labels
editor-contrib Editor collection of extras feature-request Request for new features or functionality languages-diagnostics Source problems reporting
Milestone

Comments

@Krzysztof-Cieslak
Copy link
Contributor

F8 and Shift + F8 navigation between diagnostic is really nice but sometimes it would be useful to have nice view of all diagnostics in current file.

Looks like it would be fairly simple to implement, just one additional editor action in https://github.com/Microsoft/vscode/blob/2a40036dbb34aac4f5aefbe999c21f2eaf76c59b/src/vs/editor/contrib/gotoError/browser/gotoError.ts, I could try implementing it if this feature idea is accepted.

@bpasero
Copy link
Member

bpasero commented Feb 3, 2017

@Krzysztof-Cieslak did you try the Problems view? It shows below the editor all problems.

/cc @sandy081 @alexandrudima

@bpasero bpasero added editor feature-request Request for new features or functionality labels Feb 3, 2017
@Krzysztof-Cieslak
Copy link
Contributor Author

Yes, I know about Problems view. But I think that having inlined errors can be useful anyway. :)

image

Changes in code are rather small so it's not adding any complexity etc, it's command so it's opt-in by users, it's providing same UI as existing diagnostics navigation, I don't see any drawbacks
master...Krzysztof-Cieslak:inline-all-decorations

@Krzysztof-Cieslak
Copy link
Contributor Author

This is pretty much ready, If there is decision that feature proposal is accepted, I'll make PR.

@sandy081
Copy link
Member

sandy081 commented Feb 6, 2017

@jrieken FYI

@jrieken jrieken added the error-list Problems view label Feb 6, 2017
@jrieken
Copy link
Member

jrieken commented Feb 6, 2017

I like but there some technical challenges because of some shortcomings of the current implementation. The problem is that the zone widget with the little arrow on top can only be shown when its target line is rendered. Therefore it always reveals that line to enforce rendering. That's not a problem with how we use it today because goto error reveals the error anyways. However, it's a different story when showing all errors, the last one will always be revealed...

In short, I'd happily review/guide a PR for this but it is a little bit of work...

@Gruntfuggly
Copy link

There is an extension in the marketplace called ErrorLens which does this: https://marketplace.visualstudio.com/items?itemName=PhilHindle.errorlens

Might be useful until it's supported natively...

@usernamehw
Copy link
Contributor

Forked ErrorLens and made a few tweaks:

  1. Update decorations for all visible editors (split/grid) instead of only active one
  2. Hot reload of settings
  3. Support of gutter icons
  4. Set priority of decorations right: Error => Warning => Info => Hint
  5. Some other features like (Excluding problems; Update only on save; Update with delay; Set colors for light theme, ...)

https://marketplace.visualstudio.com/items?itemName=usernamehw.errorlens

@alexdima alexdima added editor-contrib Editor collection of extras and removed editor labels Oct 25, 2019
@sandy081 sandy081 removed the error-list Problems view label Nov 11, 2019
@sandy081 sandy081 added this to the Backlog Candidates milestone Nov 11, 2019
@vscodebot
Copy link

vscodebot bot commented Jan 15, 2020

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

@vscodebot
Copy link

vscodebot bot commented Feb 14, 2020

🙂 This feature request received a sufficient number of community upvotes and we moved it to our backlog. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

@vscodebot vscodebot bot modified the milestones: Backlog Candidates, Backlog Feb 14, 2020
@DavidGoldman

This comment has been minimized.

@ghost

This comment has been minimized.

@hediet hediet linked a pull request Oct 26, 2021 that will close this issue
@GrayXu
Copy link

GrayXu commented Apr 8, 2023

For anyone who needs this feature, Errors Lens

@jrieken jrieken added the languages-diagnostics Source problems reporting label Dec 7, 2023
@Israel-Laguan

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editor-contrib Editor collection of extras feature-request Request for new features or functionality languages-diagnostics Source problems reporting
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants