Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to reuse opened browser pages when debugging VS Code on the Web side #197898

Closed
yiliang114 opened this issue Nov 10, 2023 · 4 comments
Closed
Labels
engineering VS Code - Build / issue tracking / etc. polish Cleanup and polish issue

Comments

@yiliang114
Copy link
Contributor

When I use the code-server.sh or code-web.sh script to debug the vscode on the web side, every time I execute the script again, I will reopen a page instead of reusing the page that has been opened before. This results in more and more of the same debug pages in the browser

Reproduction steps:

  1. clone vscode source code.
  2. yarn i
  3. Use cmd + shift + b to compile vscode and builtin extension, then call ./scripts/code-web.sh to start web
  4. The browser opens http://localhost:8080/ by default
  5. Exit ./scripts/code-web.sh and re-execute.
  6. The browser opens http://localhost:8080/ again.

bug124

Version: 1.84.2
Commit: 1a5daa3
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/118.0.0.0 Safari/537.36
Embedder: vscode.dev

@roblourens
Copy link
Member

Maybe it works to reload instead of starting the script over again and again? We probably wouldn't fix this but maybe would take a PR that doesn't complicate the script too much

@roblourens roblourens added polish Cleanup and polish issue engineering VS Code - Build / issue tracking / etc. labels Dec 10, 2023
@roblourens roblourens removed their assignment Dec 10, 2023
@roblourens
Copy link
Member

You can submit a simple PR if you like but I'm going to close this

@yiliang114
Copy link
Contributor Author

You can submit a simple PR if you like but I'm going to close this

I'll give it a try

@github-actions github-actions bot locked and limited conversation to collaborators Jan 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
engineering VS Code - Build / issue tracking / etc. polish Cleanup and polish issue
Projects
None yet
Development

No branches or pull requests

2 participants