Test: floating windows

[bpasero]

Refs: #10121

• macOS @meganrogge
• linux @chrmarti
• windows @Tyriar

Complexity: 5

Create Issue

---

Floating windows will be available in stable for our next release. A lot of changes went in during this milestone to polish the experience. This test plan covers the additions.

Overal

• watch out for errors in devtools from your testing
• watch out for screen cheese or missing CSS styles that cause rendering issues
• enable the "Open Editors" view to easily see all opened windows and ensure you can navigate to them

Drag and Drop

• run this test both with dragging editor tabs as well as tab groups [1]
• drag and drop outside of VS Code and verify a floating window opens with the tab(s) at the location you dropped
• verify this with multi-monitor setup and ensure the location is correct
• drag and drop into editor area of other VS Code windows (both floating or other workspace windows) and verify you can still drop tab(s) into other windows without being forced to open a floating window
• verify you never see a floating window open for when you drop over any VS Code window, including the one you start the drag operation from
• set workbench.editor.dragToOpenWindow: false and verify that dropping outside the window no longer opens floating windows
• press Alt key before dragging and verify you get the opposite drop behaviour of what workbench.editor.dragToOpenWindow is configured to in both cases

[1] you can drag tab group by dragging the empty space after the last tab

Custom Title

• configure window.titleBarStyle: custom
• open floating windows and verify you see the same custom title as in the main window (except for: no menu bar, no layout controls)
• verify you can configure command center visibility and the update is live
• verify you can double click on title to maximize / restore
• verify you can move the floating window by dragging the custom title bar
• verify the window title reflects the active editor of the floating window
• configure window.titleBarStyle: native
• open floating windows and verify you see native title bar
• verify the window title reflects the active editor of the floating window

Status Bar

• open floating windows and verify you see a status bar with the same colors as the main window
• verify you see entries for editor status (for example line/col selection) that are specific to the active editor of the floating window
• verify you see a per-window language status indicator with a rich hover that is functional
• verify multiple windows show different editor status that is always specific to the active editor in the window
• verify status bar background color changes when you start/stop to debug

New Commands

• right click on a tab and trigger the new command "Move into New Window"
• from the "Editor Layout" top level menu (under "View > Appearance"), trigger the new commands to Move/Copy into New Window
• from the command palette, trigger the new commands to Move/Copy into New Window both for active editor and active editor group
• from the command palette in a floating window trigger the new command "Restore editors into main window" and ensure the editors of the floating window all move over

Accessibility

• enable the editor.accessibilitySupport setting for enhanced accessibility
• open floating windows
• enable a screen reader
• verify you get the active elements announced while you operate in the floating window including text editor and quick open

[meganrogge]

All works well for me from an accessibility perspective. 👏🏼

[bpasero]

@meganrogge @Tyriar @chrmarti just to clarify, in order to get to a floating window, best is to drag the tab out of the window into empty space outside the application.

If you are using this command:

Note that the resulting window is NOT a floating window but a full empty window with just the file. We always had this command for a long time and I did not just want to remove it.

The easiest to know that you are in a floating window is to ensure that sidebar and panel are not visible and cannot be made visible. In floating windows only editor area is allowed. Also, the same file opened in main window and floating windows will show changes live without the need to save. So all editors are live updating as you type.

Sorry for not making this a bit clearer!

[Tyriar]

I got through part of this today, will finish up testing tomorrow to make sure it's done right.